From owner-freebsd-stable@FreeBSD.ORG  Fri May  9 08:50:31 2008
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E06C1065675
	for <freebsd-stable@freebsd.org>; Fri,  9 May 2008 08:50:31 +0000 (UTC)
	(envelope-from dfr@rabson.org)
Received: from itchy.rabson.org (unknown [IPv6:2002:50b1:e8f2:1::143])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BA368FC16
	for <freebsd-stable@freebsd.org>; Fri,  9 May 2008 08:50:31 +0000 (UTC)
	(envelope-from dfr@rabson.org)
Received: from [IPv6:2001:470:909f:1:21b:63ff:feb8:5abc] (unknown
	[IPv6:2001:470:909f:1:21b:63ff:feb8:5abc])
	by itchy.rabson.org (Postfix) with ESMTP id 938ED3F8F;
	Fri,  9 May 2008 09:50:29 +0100 (BST)
Message-Id: <62B7297F-8795-456F-8611-40658DF327FB@rabson.org>
From: Doug Rabson <dfr@rabson.org>
To: paul.koch@statseeker.com
In-Reply-To: <200805091607.23035.paul.koch@statseeker.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v919.2)
Date: Fri, 9 May 2008 09:50:28 +0100
References: <200805081812.24692.paul.koch@statseeker.com>
	<1B6FCF23-413B-452A-B66D-3CCD6257F7BD@rabson.org>
	<200805091607.23035.paul.koch@statseeker.com>
X-Mailer: Apple Mail (2.919.2)
Cc: freebsd-stable@freebsd.org
Subject: Re: flock incorrectly detects deadlock on 7-stable and current
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 May 2008 08:50:31 -0000


On 9 May 2008, at 07:07, Paul Koch wrote:

> On Thu, 8 May 2008 06:37:00 pm Doug Rabson wrote:
>>
>>
>> Could you possibly try this patch and tell me if it helps:
>> ...
>>
> Manually applied the patch to stable kern_lockf.c  1.57.2.1.  Ran the
> flock_test program on many of our architectures and it works fine.
>
> Have also been testing our app on a single core i386 machine today  
> with
> no locking problems.  Just setup a quad core -stable amd64 build and  
> it
> also appears to be running fine now.

Thanks for that. I'll get the patch committed to current today - it  
will turn up in 7-stable in a couple of days.