From owner-svn-soc-all@freebsd.org Thu Aug 27 11:08:32 2015 Return-Path: Delivered-To: svn-soc-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 367889C2D4E for ; Thu, 27 Aug 2015 11:08:32 +0000 (UTC) (envelope-from btw@mail.ustc.edu.cn) Received: from ustc.edu.cn (email6.ustc.edu.cn [IPv6:2001:da8:d800::8]) by mx1.freebsd.org (Postfix) with ESMTP id 684631381 for ; Thu, 27 Aug 2015 11:08:30 +0000 (UTC) (envelope-from btw@mail.ustc.edu.cn) Received: from dell (unknown [110.77.7.5]) by newmailweb.ustc.edu.cn (Coremail) with SMTP id LkAmygAHuQmg795VuCaUAA--.6417S2; Thu, 27 Aug 2015 19:08:25 +0800 (CST) Date: Thu, 27 Aug 2015 19:08:21 +0800 From: Tiwei Bie To: "Bjoern A. Zeeb" Cc: svn-soc-all@FreeBSD.org Subject: Re: socsvn commit: r290244 - in soc2015/btw/head/sys: net netinet netinet6 Message-ID: <20150827110747.GA68989@dell> References: <201508270754.t7R7s13d051650@socsvn.freebsd.org> <2AC0F143-11B1-4793-B309-0D2DE3B6A995@lists.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2AC0F143-11B1-4793-B309-0D2DE3B6A995@lists.zabbadoz.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-CM-TRANSID: LkAmygAHuQmg795VuCaUAA--.6417S2 X-Coremail-Antispam: 1UD129KBjvdXoWrury3Wry3uF4fJw45tryDGFg_yoWfZFcE9F 1UKryfGa17Aa4FqrZIqFWkAFZ8J3WUAryfAayDJ39I9r98ZryfJFyfWr9Ivr13WF1agwnr uFW2qa18A34I9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbF8YjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCF04k20xvY0x0EwIxGrwCFx2IqxVCF s4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r 1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWU JVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r W3Jr0E3s1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8 JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8c6pPUUUUU== X-CM-SenderInfo: xewzqzxdloh3xvwfhvlgxou0/1tbiAQcOAVQhmDXE4AAAs1 X-BeenThere: svn-soc-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the entire Summer of Code repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2015 11:08:32 -0000 On Thu, Aug 27, 2015 at 10:13:38AM +0000, Bjoern A. Zeeb wrote: > > > On 27 Aug 2015, at 07:54 , btw@FreeBSD.org wrote: > > > > Author: btw > > Date: Thu Aug 27 07:54:00 2015 > > New Revision: 290244 > > URL: http://svnweb.FreeBSD.org/socsvn/?view=rev&rev=290244 > > > > Log: > > Replace the printf()s with optional rate limited debugging for RSS. > > > > Modified: > > soc2015/btw/head/sys/net/rss_config.c > > soc2015/btw/head/sys/net/rss_config.h > > soc2015/btw/head/sys/netinet/in_rss.c > > soc2015/btw/head/sys/netinet6/in6_rss.c > > > Ideally you’d add SDT probes for that as well; printfs for debugging is something we should really stop avoiding I think. > Got it! Thank you so much for your suggestions! :-) I also think it is a good idea to use SDT probes. This patch is the draft of this review [1]. I will forward it to adrian@ and gnn@. Best regards, Tiwei Bie [1] https://reviews.freebsd.org/D3471.