From owner-svn-src-all@freebsd.org Thu Dec 29 18:09:01 2016 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B21ABC969BC; Thu, 29 Dec 2016 18:09:01 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A3031612; Thu, 29 Dec 2016 18:09:01 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-wm0-x241.google.com with SMTP id u144so67563235wmu.0; Thu, 29 Dec 2016 10:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=uxuFp7Xe/E1EEnH+TWX5XbO3EsrDUoO724HR46wCKME=; b=WKBJzMGRzNItwmqC85NEZX3uyWofimCicLtlV47znuzdDpuIC0YLorKfgi2RmzZNEP 6siXZIe118U78TSmBQhwskROFRc5kXNgkJxxFDB0OyitN4LDzBCp8YogOWKgRNc2YYyd ylVrH4D2hfLPPN0mRbn3qCN6JKzoxp2Plchffp7ibZO6nsxQgqZR8rDL9d39ndFOjcWv XCDMFKSMPFyN0F5QKq1yix73rC6KuAVx9wWK3+QtE4AKMGiNOANIfqjFWF1BLupH1onN lnW3T225XY/d3ndS/8RnuzzgN1GC18dhtjbNb4npvkqxf98aixEUP3IN0GdO6biKqA6l 4hHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uxuFp7Xe/E1EEnH+TWX5XbO3EsrDUoO724HR46wCKME=; b=QYO5uxQXKjziNovXFU93utu/npvTxuXK52LyC/9JOKtz6BGIFOoX2V/h/13Y05A58W PeBcdRxCmF5iolkIOs+9Q0wsa+B1qSwLWb+ugUsekbeIWSr7eXliqI8LgNJWF+9IzRpJ BcgG+jYzyjxEWafmUjNw8wdNKBV4vtivivcpu88QAzjNSQaADFonHoqP4skjbF+DWDe9 qtjroti6EF7xm4A9D/ab1lAk87VsEErF/NNl3hnWKi9pJIhLxplT869dj9Um9mzXVJbn AHZ5k/iOfhstnC1yUvFMAD20lSqSjMEttgu+CMOxv4rtwmQ3pEl2HOQJ+wHwV2kVps6+ UShg== X-Gm-Message-State: AIkVDXJklLQazx5+4ei0BTWp9EQQvYwOZMG6dBxP+11bUzsuun7cAy/uNYyho7eowStB4A== X-Received: by 10.28.136.80 with SMTP id k77mr38560690wmd.57.1483034939337; Thu, 29 Dec 2016 10:08:59 -0800 (PST) Received: from spectre.mavhome.dp.ua ([92.38.100.11]) by smtp.gmail.com with ESMTPSA id l67sm66249685wmf.20.2016.12.29.10.08.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Dec 2016 10:08:58 -0800 (PST) Sender: Alexander Motin <mavbsd@gmail.com> Subject: Re: svn commit: r310778 - head/sys/cam/ctl To: Mateusz Guzik <mjguzik@gmail.com> References: <201612291509.uBTF9YxM055182@repo.freebsd.org> <20161229180223.GD29676@dft-labs.eu> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Alexander Motin <mav@FreeBSD.org> Message-ID: <88db7459-d498-7c19-d335-e9e33cf5b529@FreeBSD.org> Date: Thu, 29 Dec 2016 20:08:57 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161229180223.GD29676@dft-labs.eu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/> List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 29 Dec 2016 18:09:01 -0000 On 29.12.2016 20:02, Mateusz Guzik wrote: > On Thu, Dec 29, 2016 at 03:09:34PM +0000, Alexander Motin wrote: >> Author: mav >> Date: Thu Dec 29 15:09:34 2016 >> New Revision: 310778 >> URL: https://svnweb.freebsd.org/changeset/base/310778 >> >> Log: >> Improve use of I/O's private area. >> >> - Since I/Os are allocates from per-port pools, make allocations store >> pointer to CTL softc there, and use it where needed instead of global. >> - Created bunch of helper macros to access LUN, port and CTL softc. >> > > This fails to build with: > > sys/modules/ctl/../../cam/ctl/ctl.c:12522:27: error: member reference > base type 'void' is not a structure or union > mtx_assert(&CTL_SOFTC(io)->ctl_lock, MA_NOTOWNED); > > Looks like thep roblem is that CTL_SOFTC indeed does not cast and > returns void instead: > +#define CTL_SOFTC(io) ((io)->io_hdr.ctl_private[CTL_PRIV_LUN].ptrs[1]) Thank you! Fixed. -- Alexander Motin