From owner-freebsd-bugs@freebsd.org Mon Jan 21 07:01:25 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6AAB814929B2 for ; Mon, 21 Jan 2019 07:01:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id CF9C7718DA for ; Mon, 21 Jan 2019 07:01:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8493F14929B1; Mon, 21 Jan 2019 07:01:24 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4311114929B0 for ; Mon, 21 Jan 2019 07:01:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CC637718D2 for ; Mon, 21 Jan 2019 07:01:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 06A0F4766 for ; Mon, 21 Jan 2019 07:01:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x0L71M21000313 for ; Mon, 21 Jan 2019 07:01:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x0L71MqW000309 for bugs@FreeBSD.org; Mon, 21 Jan 2019 07:01:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232527] bsd.prog.mk includes bsd.nls.mk unconditionally. Date: Mon, 21 Jan 2019 07:01:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jarrod@downtools.com.au X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 07:01:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232527 jarrod@downtools.com.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jarrod@downtools.com.au --- Comment #1 from jarrod@downtools.com.au --- With the same options in src.conf, this also appears to affect the building= of some ports under Poudriere as bsd.nls.mk is also blindly included by share/mk/bsd.lib.mk (releng/12.0 r340773 line 440). =3D=3D=3D> Building for libsunacl-1.0.1 make[1]: "/usr/share/mk/bsd.opts.mk" line 101: warning: "NO_PROFILE is defi= ned, but deprecated. Please use MK_PROFILE=3Dno instead." make[1]: "/usr/share/mk/bsd.lib.mk" line 440: Could not find bsd.nls.mk make[1]: Fatal errors encountered -- cannot continue make[1]: stopped in /wrkdirs/usr/ports/sysutils/libsunacl/work/libsunacl-1.= 0.1 *** Error code 1 Stop. make: stopped in /usr/ports/sysutils/libsunacl According to tools/build/mk/OptionalObsoleteFiles.inc (releng/12.0 r338929 = line 6283), which is included by ObsoleteFiles.inc, usr/share/mk/bsd.nls.mk is considered optional (well, assuming my interpretation is correct) when NLS support is disabled therefor is deleted on a "make delete-old". .if ${MK_NLS} =3D=3D no OLD_DIRS+=3Dusr/share/nls/ OLD_DIRS+=3Dusr/share/nls/C OLD_FILES+=3Dusr/share/mk/bsd.nls.mk <-- this one here OLD_FILES+=3Dusr/share/nls/C/ee.cat OLD_DIRS+=3Dusr/share/nls/af_ZA.ISO8859-1 If this is the case, the file cannot be relied upon and should be .sinclude= 'd instead or unmarked as being optional in OptionalObsoleteFiles.inc. Probab= ly the latter is the safer? --=20 You are receiving this mail because: You are the assignee for the bug.=