From owner-freebsd-current@FreeBSD.ORG Tue May 16 02:15:41 2006 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FD8016A4DD; Tue, 16 May 2006 02:15:41 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk.360sip.com [72.236.70.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF23243D45; Tue, 16 May 2006 02:15:40 +0000 (GMT) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.0.38] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.6/8.13.6) with ESMTP id k4G2FbfN028448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 May 2006 19:15:39 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Message-ID: <446935C6.6020900@FreeBSD.org> Date: Mon, 15 May 2006 19:15:34 -0700 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 1.5.0.2 (Windows/20060308) MIME-Version: 1.0 To: Gavin Atkinson References: <444DD7DF.6010402@FreeBSD.org> <1145956219.2968.31.camel@sos.deepcore.dk> <44681E94.9000702@FreeBSD.org> <1147686547.23488.6.camel@buffy.york.ac.uk> In-Reply-To: <1147686547.23488.6.camel@buffy.york.ac.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: "current@freebsd.org" , sos@FreeBSD.org Subject: Re: Support for ICH7 controller in PowerBook Pro X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 May 2006 02:15:41 -0000 Gavin Atkinson wrote: > On Sun, 2006-05-14 at 23:24 -0700, Maxim Sobolev wrote: >> Søren Schmidt wrote: >>> On Tir, 2006-04-25 at 01:03 -0700, Maxim Sobolev wrote: >>>> Hi Søren, >>>> >>>> Attached please find small patch which adds support for 82801GBM/GHM >>>> SATA controller found in intel-based Macs, particularly in MacBook Pro. >>>> >>>> Please review & approve. >>> I'll look into it, I think Intel has a few other new chips I should add >>> in the same go, give me a few days... >> Any progress with this? Few days have turned into few weeks, and I don't >> want them turn into few months. :) > > Be aware that I believe your patch is slightly wrong. As far as I can > tell the chip ID you've added is the non-AHCI version. I have the same > chip in my new Toshiba laptop, and submitted a more complete PR > (kern/97228) over the weekend. MacBook doesn't work with your patch - FreeBSD detects controller but doesn't see any disks attached to it. :( Putting AHCI back solves the problem. I wonder if Intel has shipped two different controllers with the same pci ids. Just in the case, attached is appropriate entry from pciconf -lv output: atapci1@pci0:31:2: class=0x01018f card=0x72708086 chip=0x27c48086 rev=0x02 hdr=0x00 vendor = 'Intel Corporation' device = '82801GBM/GHM (ICH7-M Family) Serial ATA Storage Controller' class = mass storage subclass = ATA And dmesg: atapci1: port 0x40d8-0x40df,0x40f4-0x40f7,0x40d0-0x40d7,0x40f0-0x40f3,0x4020-0x402f mem 0x98405000-0x984053ff irq 19 at device 31.2 on pci0 ata2: on atapci1 ata3: on atapci1 ad5: 95396MB at ata2-slave SATA150 -Maxim