From owner-freebsd-threads@FreeBSD.ORG Mon Aug 25 21:00:33 2003 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90AE916A4BF; Mon, 25 Aug 2003 21:00:33 -0700 (PDT) Received: from exchhz01.viatech.com.cn (ip-167-164-97-218.anlai.com [218.97.164.167]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3F6C843FE0; Mon, 25 Aug 2003 21:00:15 -0700 (PDT) (envelope-from davidxu@viatech.com.cn) Received: from viatech.com.cn (ip-240-1-168-192.rev.dyxnet.com [192.168.1.240]) by exchhz01.viatech.com.cn with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21) id RKXCRQ83; Tue, 26 Aug 2003 11:41:45 +0800 Message-ID: <3F4ADC3D.1080908@viatech.com.cn> Date: Tue, 26 Aug 2003 12:04:13 +0800 From: David Xu User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030723 Thunderbird/0.1 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jeff Roberson References: <20030825234011.F12093-100000@mail.chesapeake.net> In-Reply-To: <20030825234011.F12093-100000@mail.chesapeake.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: "deischen@freebsd.org" cc: "threads@freebsd.org" cc: Sheldon Hearn cc: "freebsd-java@freebsd.org" Subject: Re: vmark hangs with libthr and libkse X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2003 04:00:33 -0000 Jeff Roberson wrote: >On Mon, 25 Aug 2003, David Xu wrote: > > > >>Sheldon Hearn wrote: >> >> >> >>>On (2003/08/25 15:47), David Xu wrote: >>> >>> >>> >>> >>> >>>>>I heartily endorse your patch. :-) >>>>> >>>>> >>>>> >>>>> >>>>> >>>>Thanks, I am pleased to see libkse works. :-) >>>>However don't expect I will commit it, kernel scheduler interface is a >>>>bit weird, so >>>>I won't try to add another weird code. >>>> >>>> >>>> >>>> >>>Does Jeff know about your patch? Perhaps he'd be willing to review and >>>commit, since he's the original author of SCHED_ULE. >>> >>> >>> >>> >>No, I think he does not know the patch. >>Please don't commit it, there is a performance problem, after each time >>a thread is exited, >>I must exit a kse and then let scheduler reinitialized it. In general, I >>needn't manage a struct kse, >>it should be a scheduler internal data. >> >> >> > >Why do you need to do adjustrunqueue() in sched_prio? I also don't >understand the case in sched_switchout(). Can you please explain that? > > adjustrunqueue maintains kg_last_assigned and related things, when a thread's priority is changed, the thread might no longer can be in scheduler's run queue, instead it will be in ksegrp's runqueue, because there is higher priority thread, and a KSE it attached should be detached now, and the KSE will attach to another higher priority thread, ULE ignores this requirement, as I can understand, ULE is only aware of 1:1 between KSE and thread. It would be nice if scheduler interface is thread aware but not kse aware. >Other than that this patch seems fine. KSE is technically missing the >proper sched api calls which is why ULE doesn't work with it. > >Cheers, >Jeff > >_______________________________________________ >freebsd-threads@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-threads >To unsubscribe, send any mail to "freebsd-threads-unsubscribe@freebsd.org" > > >