From owner-freebsd-current@FreeBSD.ORG Mon Mar 3 18:27:18 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 581861065670 for ; Mon, 3 Mar 2008 18:27:18 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from ik-out-1112.google.com (ik-out-1112.google.com [66.249.90.179]) by mx1.freebsd.org (Postfix) with ESMTP id DFFFF8FC1B for ; Mon, 3 Mar 2008 18:27:17 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: by ik-out-1112.google.com with SMTP id b35so293797ika.3 for ; Mon, 03 Mar 2008 10:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=Y5c7SvBHg4Flo6S77II4W0vC8vPw24Cqmol+JHix0jk=; b=YnkMBEsdHdD+umKofZdmTrWa2Z/cgvY5OySkWz+SsA7akednYcz/VtwxJ53Y1m9E6ngVrWrEl0tc5B3tyV4W3sLxnSdU2NENcRek0vTSy47+OjdeAXyFwN3E3JXuNl3RAXOR6vQFuT2KEZCj1z4rJZYG45C9fgoQ7cXyOs0FN50= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ChcOep8ifVC/rnKviigVmdpLmTR8bZBdrzPkkWftZNV5X5JO8U+QyNRqpkGC+VFUJPrZ7+ZdDAcL0k9WpmI1F2rys3qpBtUS1B+rZNBznNzqcKSdnE4+0VU/gHDcLGq/A+pjrQQ///GdmZ04pplTY/hJ2SSQjQwPCuQNynZDLQw= Received: by 10.78.186.9 with SMTP id j9mr880194huf.14.1204568835737; Mon, 03 Mar 2008 10:27:15 -0800 (PST) Received: by 10.78.46.11 with HTTP; Mon, 3 Mar 2008 10:27:15 -0800 (PST) Message-ID: Date: Mon, 3 Mar 2008 21:27:15 +0300 From: pluknet To: "Kostik Belousov" In-Reply-To: <20080303164353.GW57756@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080303133406.GV57756@deviant.kiev.zoral.com.ua> <20080303164353.GW57756@deviant.kiev.zoral.com.ua> Cc: FreeBSD Current Subject: Re: panic: mutex Giant owned at nfs_syscalls.c:556 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2008 18:27:18 -0000 On 03/03/2008, Kostik Belousov wrote: [snip] > To summarize, I need both the tcpdump and kernel/witness messages from > the panic. > I'm sorry. Here it is. http://pluknet.nm.ru/dev/tcpdump-nfsserver-full.raw The messages (same as unread msgbuf in initial posting, hand-scribed): panic: mutex Giant owned at /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_syscalls.c:556 KDB: enter: panic [thread pid 601 tid 100055 ] Stopped at kdb_enter+0x3a: movl $0,kdb_why db> show locks exclusive sleep mutex nfsd_mtx r = 0 (0xc2e0af40) locked @ /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_syscalls.c:501 exclusive sleep mutex Giant r = 0 (0xc07e6410) locked @ /usr/src/sys/kern/vfs_lookup.c:663 > Nevertheless, the patch below might help with the panic during > the unlinking (not tested). > > diff --git a/sys/nfsserver/nfs_serv.c b/sys/nfsserver/nfs_serv.c > index 446651d..87e1aaa 100644 > --- a/sys/nfsserver/nfs_serv.c > +++ b/sys/nfsserver/nfs_serv.c > @@ -2146,7 +2146,7 @@ nfsrv_remove(struct nfsrv_descript *nfsd, struct nfssvc_sock *slp, > nfsfh_t nfh; > fhandle_t *fhp; > struct mount *mp = NULL; > - int vfslocked; > + int vfslocked, vfslocked1; > > nfsdbprintf(("%s %d\n", __FILE__, __LINE__)); > ndclear(&nd); > @@ -2168,7 +2168,11 @@ nfsrv_remove(struct nfsrv_descript *nfsd, struct nfssvc_sock *slp, > nd.ni_cnd.cn_flags = LOCKPARENT | LOCKLEAF | MPSAFE; > error = nfs_namei(&nd, fhp, len, slp, nam, &md, &dpos, > &dirp, v3, &dirfor, &dirfor_ret, td, FALSE); > - vfslocked = NDHASGIANT(&nd); > + vfslocked1 = NDHASGIANT(&nd); > + if (vfslocked && vfslocked1) > + VFS_UNLOCK_GIANT(vfslocked1); > + if (vfslocked || vfslocked1) > + vfslocked = 1; > if (dirp && !v3) { > vrele(dirp); > dirp = NULL; > > Now the last lock triplex looks like: vfslocked lock in /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_serv.c, 2161 vfslocked lock in /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_srvsubs.c, 1106 vfslocked lock in /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_srvsubs.c, 673 vfslocked unlock in /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_srvsubs.c, 916 vfslocked1 unlock in /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_serv.c, 2173 ^^^ vfslocked unlock in /usr/src/sys/modules/nfsserver/../../nfsserver/nfs_serv.c, 2238 And no panic. Thanks. wbr, pluknet