From nobody Mon Aug 22 01:10:20 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M9vRg5Yltz4ZKZL; Mon, 22 Aug 2022 01:10:23 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4M9vRf3hVrz40NV; Mon, 22 Aug 2022 01:10:22 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Received: from [192.168.5.3] ([76.132.248.201]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 27M1ALLb096221 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Sun, 21 Aug 2022 18:10:21 -0700 (PDT) (envelope-from yuri@FreeBSD.org) X-Authentication-Warning: shell1.rawbw.com: Host [76.132.248.201] claimed to be [192.168.5.3] Message-ID: Date: Sun, 21 Aug 2022 18:10:20 -0700 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: 600312a9118b - main - Mk/Uses/python.mk: Add USE_PYTHON=build to support pyproject.toml based projects Content-Language: en-US To: Charlie Li , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202208212016.27LKGAYJ050818@gitrepo.freebsd.org> <4312690d-8b9e-8634-7d68-deb26213908b@tsoft.com> From: Yuri In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4M9vRf3hVrz40NV X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 198.144.192.42 is neither permitted nor denied by domain of yuri@FreeBSD.org) smtp.mailfrom=yuri@FreeBSD.org X-Spamd-Result: default: False [0.50 / 15.00]; VIOLATED_DIRECT_SPF(3.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-ports-main@FreeBSD.org,dev-commits-ports-all@FreeBSD.org]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; DMARC_NA(0.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[yuri]; ARC_NA(0.00)[]; ASN(0.00)[asn:7961, ipnet:198.144.192.0/19, country:US]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; HAS_XAW(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N Charlie, On 8/21/22 17:59, Charlie Li wrote: > Yuri wrote: >> python@ didn't say anything in the review for 14 days. >> > That doesn't mean it was approved, especially when perhaps the > maintainer-approval flag was omitted. The policy says that there is 14 days maintainer's timeout on all items with MAINTAINER: xx@FreeBSD.org except when xx==portmgr. So this is a maintainer's timeout based on the official policy. > We do not just add stuff into Uses/*.mk files without proper design > and qualification. Specifically, Uses/python.mk is fragile as it is, > with USE_PYTHON=distutils for instance. This needs time and effort to > germinate. It wasn't "just added". The maintainer had a chance to voice his concerns, and he didn't. > There were open questions in the discussion, which are intentionally > not specific because the overall design is not currently firm. It's impossible to do anything about non-specific questions. It was a window to discuss any specific improvements and nobody voiced anything specific. Could you please formulate a specific objection. Do you run some command that fails that shouldn't fail? BTW, I received 2 private e-mails from committers with unofficial thumbs ups. So it was actually reviewed. Regards, Yuri