From owner-freebsd-multimedia Tue Feb 3 08:34:22 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA18116 for freebsd-multimedia-outgoing; Tue, 3 Feb 1998 08:34:22 -0800 (PST) (envelope-from owner-freebsd-multimedia@FreeBSD.ORG) Received: from labinfo.iet.unipi.it (labinfo.iet.unipi.it [131.114.9.5]) by hub.freebsd.org (8.8.8/8.8.8) with SMTP id IAA18102 for ; Tue, 3 Feb 1998 08:34:17 -0800 (PST) (envelope-from luigi@labinfo.iet.unipi.it) Received: from localhost (luigi@localhost) by labinfo.iet.unipi.it (8.6.5/8.6.5) id QAA06191; Tue, 3 Feb 1998 16:03:18 +0100 From: Luigi Rizzo Message-Id: <199802031503.QAA06191@labinfo.iet.unipi.it> Subject: bt848 feedback... To: multimedia@FreeBSD.ORG, hasty@rah.star-gate.com Date: Tue, 3 Feb 1998 16:03:18 +0100 (MET) X-Mailer: ELM [version 2.4 PL23] Content-Type: text Sender: owner-freebsd-multimedia@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe freebsd-multimedia" In the latest release of the Bt848 code, I noticed the BT848_I2CWR ioctl that I submitted some time ago has been put in video_ioctl(), but it really belongs in tuner_ioctl() , where other I2C devices are also accessed. It's just a matter of moving the block in the other function (and moving the variable declarations at the beginning of video_ioctl, a hundred lines above... what was wrong with declaring variables within the block they are used, as in the patch I submitted!). Oh btw the code works perfectly on 2.2.1 cheers luigi -----------------------------+-------------------------------------- Luigi Rizzo | Dip. di Ingegneria dell'Informazione email: luigi@iet.unipi.it | Universita' di Pisa tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy) fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/ _____________________________|______________________________________