From owner-freebsd-current@FreeBSD.ORG Tue Mar 9 10:46:50 2010 Return-Path: Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 97C8C106566B for ; Tue, 9 Mar 2010 10:46:50 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from sippysoft.com (gk1.360sip.com [72.236.70.240]) by mx1.freebsd.org (Postfix) with ESMTP id 50A098FC12 for ; Tue, 9 Mar 2010 10:46:50 +0000 (UTC) Received: from [192.168.1.38] (S0106005004e13421.vs.shawcable.net [70.71.175.212]) (authenticated bits=0) by sippysoft.com (8.14.3/8.14.3) with ESMTP id o29AVQxE006707 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Mar 2010 02:31:27 -0800 (PST) (envelope-from sobomax@sippysoft.com) Message-ID: <4B962381.2060300@sippysoft.com> Date: Tue, 09 Mar 2010 02:31:29 -0800 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: "Jayachandran C." References: <98a59be81003040504x6e97fbaeqeb10f8ea7bedb7b9@mail.gmail.com> <4b94b8d8.c501be0a.4ce5.760a@mx.google.com> In-Reply-To: <4b94b8d8.c501be0a.4ce5.760a@mx.google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 09 Mar 2010 12:32:41 +0000 Cc: FreeBSD Current Subject: Re: newfs broken in -CURRENT after 204654 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2010 10:46:50 -0000 Jayachandran C. wrote: > On Thu, Mar 04, 2010 at 06:34:03PM +0530, C. Jayachandran wrote: >> I'm testing this on the mips platform, but I think there is an issue >> with change that made sectorsize int64_t, because the ioctl >> DIOCGSECTORSIZE used to read sector size seems to take u_int. This >> quick change fixes it for me (sample patch - may be whitespace >> damaged). > > I'm trying this one more time, since the issue is still unresolved. > > newfs(8) broke for big-endian systems since revision 204654. This change > made sectorsize variable int64_t, and now it cannot be passed to the ioctl > DIOCGSECTORSIZE. > > The patch below (updated from the previous one) fixes it, please review and > apply if correct. Sorry about that, I've just applied a fix. Regards, -- Maksym Sobolyev Sippy Software, Inc. Internet Telephony (VoIP) Experts T/F: +1-646-651-1110 Web: http://www.sippysoft.com MSN: sales@sippysoft.com Skype: SippySoft