From owner-freebsd-current@FreeBSD.ORG Tue Apr 17 09:49:47 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C3FE1106566B; Tue, 17 Apr 2012 09:49:47 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 771858FC17; Tue, 17 Apr 2012 09:49:47 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:920:4d88:e4b9:4d05] (unknown [IPv6:2001:7b8:3a7:0:920:4d88:e4b9:4d05]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 6B88C5C37; Tue, 17 Apr 2012 11:49:46 +0200 (CEST) Message-ID: <4F8D3CB8.5090907@FreeBSD.org> Date: Tue, 17 Apr 2012 11:49:44 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120410 Thunderbird/12.0 MIME-Version: 1.0 To: Chris , Chris Rees , Current FreeBSD , "O. Hartmann" , Doug Barton References: <4F520523.90406@zedat.fu-berlin.de> <4F52286E.4030608@FreeBSD.org> <4F523C1A.4060008@zedat.fu-berlin.de> <4F8BBFF3.50205@FreeBSD.org> <20120416230857.GA26957@mech-cluster241.men.bris.ac.uk> <4F8D3565.2020803@FreeBSD.org> <20120417093652.GA29091@mech-cluster241.men.bris.ac.uk> In-Reply-To: <20120417093652.GA29091@mech-cluster241.men.bris.ac.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: "/sys/conf/kmod.mk", line 111: Malformed conditional (${MK_CLANG_IS_CC} X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2012 09:49:47 -0000 On 2012-04-17 11:36, Anton Shterenlikht wrote: > On Tue, Apr 17, 2012 at 11:18:29AM +0200, Dimitry Andric wrote: ... >> That said, i think it may be time to bow to the pressure, and just put a >> fixup for this issue in kmod.mk, and the other .mk files, like I >> initially did in r232473, but with a BIG FAT WARNING printed, so you at >> least know you are attempting to shoot your extremities. :) > > No, I wouldn't want that. > It's just that I thought the ports system > never uses anything from /usr/src. Well, only the ports that build kernel modules need it, as far as I know. This is because in FreeBSD we do not install the 'full' kernel headers anywhere during installworld. Maybe we could adopt the Linux solution and dump them somewhere in a versioned directory. :) > Perhaps the ports which do use /sys should > print a warning to the user. Something like > "before building this port, make sure your > installed world version matches the version > of your FreeBSD sources." > > By the way, what would happen if I try > to build those ports with no /sys at all? It would hopefully error out. If you look in /usr/share/mk/bsd.kmod.mk, you will see this at the bottom: .if !defined(SYSDIR) || !exists(${SYSDIR}/kern/) || \ !exists(${SYSDIR}/conf/kmod.mk) .error Unable to locate the kernel source tree. Set SYSDIR to override. .endif So, setting SYSDIR to the correct directory is also a possible solution.