From owner-freebsd-current@FreeBSD.ORG Sun Oct 21 22:13:40 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57F2C16A468 for ; Sun, 21 Oct 2007 22:13:40 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id 19D0513C49D for ; Sun, 21 Oct 2007 22:13:39 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 5428 invoked by uid 399); 21 Oct 2007 06:13:00 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 21 Oct 2007 06:13:00 -0000 X-Originating-IP: 127.0.0.1 Date: Sat, 20 Oct 2007 23:12:58 -0700 (PDT) From: Doug Barton To: Jose Alonso Cardenas Marquez In-Reply-To: <7c58fcfc0710180838keb742acv91799d1d68aa5c19@mail.gmail.com> Message-ID: References: <7c58fcfc0710161455t20792d7dqa349ff157674048d@mail.gmail.com> <7c58fcfc0710180838keb742acv91799d1d68aa5c19@mail.gmail.com> X-message-flag: Outlook -- Not just for spreading viruses anymore! X-OpenPGP-Key-ID: 0xD5B2F0FB Organization: http://www.FreeBSD.org/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org Subject: Re: Call for Testers: dialog 1.1-20070930 update X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2007 22:13:40 -0000 On Thu, 18 Oct 2007, Jose Alonso Cardenas Marquez wrote: > 2007/10/17, Doug Barton : >> If you can make some patches against HEAD I'd be glad to give them a try, >> but I lack the time to integrate them myself right now. >> > > Done, could you see again? Ok, I'm trying this again, and I have a few comments. First about your patches ... it would be better if you could use 'cvs diff' to generate them, as it would avoid a few issues. The worst of which is that you included the CVS directories in your patches for -current which created a lot of drama in my checked out tree. The second thing I've come up against so far is while trying to build this stuff as part of a world build it fails in the library build phase because in the libdialog Makefile it tries to install files to /usr/obj/src/tmp/usr/share/examples/libdialog which doesn't exist. I'm not enough of a bmake expert to tell you how to get it to create an extra OBJ directory for you, but I'm sure someone can. :) I got around this issue with brute force, I created the directory by hand. The next problem with your patch is that the dialog patch for the Makefile has SRCDIR as */libdialog.new. That was easily corrected. As for problems with buildworld, in addition to the problems you mentioned with sysinstall (which I'm ignoring) there is also a libdialog dependency in usr.sbin/tzsetup. I can add the following to the Makefile to avoid having it fail when it can't find dlg_config.h (which may or may not be the right solution): -CFLAGS+= -I${.CURDIR} +CFLAGS+= -I${.CURDIR} -I${.CURDIR}/../../gnu/lib/libdialog But the build for tzsetup will still fail because it expects the old version of libdialog. (Please note that there may be other victims here as well, I have a not of NO_FOO knobs in my make.conf for my everyday system.) The build for usr.sbin/sade also fails, but I think that may have been part of what you were referring to in regards to sysinstall? Ok, now for the good news! After getting it built and installed I ran through every single OPTIONS dialog for the ports that I have installed, plus a few other things (pkg-install messages), and it works great. I particularly like the fact that you can now press the enter key to select "yes" without having to tab to it. So I definitely think you're on the right track here, although there is obviously some work to go. hth, Doug -- This .signature sanitized for your protection