From owner-freebsd-stable@FreeBSD.ORG  Fri Apr  9 17:20:58 2004
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 75D6216A4CF
	for <freebsd-stable@freebsd.org>;
	Fri,  9 Apr 2004 17:20:58 -0700 (PDT)
Received: from relay.pair.com (relay.pair.com [209.68.1.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id DE4FD43D5A
	for <freebsd-stable@freebsd.org>;
	Fri,  9 Apr 2004 17:20:57 -0700 (PDT)
	(envelope-from rooneg@electricjellyfish.net)
Received: (qmail 60480 invoked from network); 10 Apr 2004 00:20:56 -0000
Received: from ool-435713c1.dyn.optonline.net (HELO ?192.168.0.2?)
	(67.87.19.193)
	by relay.pair.com with SMTP; 10 Apr 2004 00:20:56 -0000
X-pair-Authenticated: 67.87.19.193
In-Reply-To: <200404091207.10055.dfr@nlsystems.com>
References: <200404091207.10055.dfr@nlsystems.com>
Mime-Version: 1.0 (Apple Message framework v613)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <EA11BD5C-8A84-11D8-817F-000393CE23F4@electricjellyfish.net>
Content-Transfer-Encoding: 7bit
From: Garrett Rooney <rooneg@electricjellyfish.net>
Date: Fri, 9 Apr 2004 20:20:47 -0400
To: Doug Rabson <dfr@nlsystems.com>
X-Mailer: Apple Mail (2.613)
cc: freebsd-current@freebsd.org
cc: freebsd-stable@freebsd.org
Subject: Re: Valgrind for FreeBSD
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Apr 2004 00:20:58 -0000


On Apr 9, 2004, at 7:07 AM, Doug Rabson wrote:

> As some of you might be aware, recently I've been working on porting 
> the
> excellent valgrind debugger to FreeBSD (both -stable and -current). If
> you are interested in trying it out, you can find details on how to get
> the latest version at http://www.rabson.org/#valgrind. Enjoy...

For anyone trying to build on FreeBSD 5.1, it requires a small tweak, 
since libc_r in that version did not have support for 
pthread_spinlock_t's.  I believe this is the correct change, since 
__FreeBSD_version 501107 seems to be the next bump after the addition 
of pthread_spinlock_t support.

-garrett

Index: coregrind/arch/x86-freebsd/vg_libpthread.c
===================================================================
--- coregrind/arch/x86-freebsd/vg_libpthread.c  (revision 325)
+++ coregrind/arch/x86-freebsd/vg_libpthread.c  (working copy)
@@ -2774,7 +2774,7 @@

  /* POSIX spinlocks, taken from glibc linuxthreads/sysdeps/i386 */

-#if __FreeBSD__ == 5
+#if __FreeBSD_version >= 501107
  int pthread_spin_init(pthread_spinlock_t *lockp, int pshared)
  {
     struct pthread_spinlock *lock = my_malloc(sizeof(struct 
pthread_spinlock));