From owner-cvs-all@FreeBSD.ORG Sun Apr 1 10:00:13 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D448F16A403 for ; Sun, 1 Apr 2007 10:00:13 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from pd4mo3so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.freebsd.org (Postfix) with ESMTP id A84C513C457 for ; Sun, 1 Apr 2007 10:00:13 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from pd2mr2so.prod.shaw.ca (pd2mr2so-qfe3.prod.shaw.ca [10.0.141.109]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0JFT00FPND4AYB50@l-daemon> for cvs-all@FreeBSD.org; Sun, 01 Apr 2007 04:00:10 -0600 (MDT) Received: from pn2ml8so.prod.shaw.ca ([10.0.121.152]) by pd2mr2so.prod.shaw.ca (Sun Java System Messaging Server 6.2-7.05 (built Sep 5 2006)) with ESMTP id <0JFT00KYWD4AIUG1@pd2mr2so.prod.shaw.ca> for cvs-all@FreeBSD.org; Sun, 01 Apr 2007 04:00:10 -0600 (MDT) Received: from hexahedron.daemonology.net ([24.82.18.31]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with SMTP id <0JFT0025MD48E1C0@l-daemon> for cvs-all@FreeBSD.org; Sun, 01 Apr 2007 04:00:09 -0600 (MDT) Received: (qmail 965 invoked from network); Sun, 01 Apr 2007 09:59:53 +0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; Sun, 01 Apr 2007 09:59:53 +0000 Date: Sun, 01 Apr 2007 02:59:53 -0700 From: Colin Percival In-reply-to: <20070401091501.GK18105@deviant.kiev.zoral.com.ua> To: Kostik Belousov Message-id: <460F8299.20307@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Enigmail-Version: 0.94.0.0 References: <20070401070403.16724517E2@repoman.freebsd.org> <20070401091501.GK18105@deviant.kiev.zoral.com.ua> User-Agent: Thunderbird 1.5.0.9 (X11/20061227) Cc: cvs-src@FreeBSD.org, Kris Kennaway , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_vr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2007 10:00:13 -0000 Kostik Belousov wrote: > On Sun, Apr 01, 2007 at 07:03:43AM +0000, Kris Kennaway wrote: >> Modified files: >> sys/pci if_vr.c >> Log: >> Fix a search-and-replace bug that slipped through my diff review of the >> Giant pushdown. > > Did you ever test _your_ changes, at least with half of the care you > put into finding bugs in commits of others ? > > You fixed the if_vr.c, but not the flag definition in if_vrreg.h, thus > breaking the build ! I pointed this out to Kris a couple of hours ago, but by that point the CVS meisters were already partway through undoing Kris' commit due to an unrelated issue (accidentally taking files off the vendor branch), so we agreed that it was easiest just to wait for the entire commit to be undone rather than fixing this with another commit. Judging by what I see at http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/, it looks like everything has been reverted now, so hopefully Kris can go ahead and redo his original commit later today without any of the changes which slipped in by mistake. Colin Percival