From owner-svn-ports-all@FreeBSD.ORG  Sun Apr 12 14:27:19 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9CA22D78;
 Sun, 12 Apr 2015 14:27:19 +0000 (UTC)
Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [IPv6:2a01:e0c:1:1599::10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 60D388DD;
 Sun, 12 Apr 2015 14:27:19 +0000 (UTC)
Received: from [192.168.1.22] (unknown [78.194.61.125])
 by smtp1-g21.free.fr (Postfix) with ESMTP id 8C82694009A;
 Sun, 12 Apr 2015 16:25:18 +0200 (CEST)
Message-ID: <552A80A0.40706@freebsd.org>
Date: Sun, 12 Apr 2015 16:26:40 +0200
From: Rodrigo OSORIO <rodrigo@freebsd.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r383869 - in head/x11/tilda: . files
References: <201504121406.t3CE6q8f015308@svn.freebsd.org>
 <20150412141020.GA40906@FreeBSD.org>
In-Reply-To: <20150412141020.GA40906@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Apr 2015 14:27:19 -0000

On 04/12/15 16:10, Alexey Dokuchaev wrote:
> On Sun, Apr 12, 2015 at 02:06:52PM +0000, Rodrigo Osorio wrote:
>> New Revision: 383869
>> URL: https://svnweb.freebsd.org/changeset/ports/383869
>>
>> Log:
>>    Upgrade tilda to latest stable release 1.2.2
>>    Fix/Rework build
>>
>>    PR:		198763
>>    Submitted by:	rodrigo (maintainer)
>
> I don't quite get it: you've submitted a PR as maintainer, only to commit
> it yourself as a comitter?  Or it should read "approved by" instead?
>
> ./danfe
>

Hi danfe,

Someone sent me a PR to request an update, I did the job and submit the 
changes with the PR number PR. I put my name as submitter because as 
said in the committer handbook : "Submitted by: The name and e-mail 
address of the person that submitted the fix; for developers, just the 
username on the FreeBSD cluster.". And I did the fix.

Regards,
- rodrigo