From owner-freebsd-current Mon Jan 21 5:55:13 2002 Delivered-To: freebsd-current@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id 92DE737B400 for ; Mon, 21 Jan 2002 05:55:10 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g0LDt4q17226; Mon, 21 Jan 2002 13:55:04 GMT (envelope-from mark@grondar.za) Received: from grondar.za (mark@localhost [127.0.0.1]) by grimreaper.grondar.org (8.11.6/8.11.6) with ESMTP id g0LDqEt39193; Mon, 21 Jan 2002 13:52:14 GMT (envelope-from mark@grondar.za) Message-Id: <200201211352.g0LDqEt39193@grimreaper.grondar.org> To: "Andrey A. Chernov" Cc: Dag-Erling Smorgrav , current@FreeBSD.ORG Subject: Re: Step5, pam_opie OPIE auth fix for review References: <20020121133326.GA35793@nagual.pp.ru> In-Reply-To: <20020121133326.GA35793@nagual.pp.ru> ; from "Andrey A. Chernov" "Mon, 21 Jan 2002 16:33:27 +0300." Date: Mon, 21 Jan 2002 13:52:13 +0000 From: Mark Murray Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Mon, Jan 21, 2002 at 14:07:48 +0100, Dag-Erling Smorgrav wrote: > > Dag-Erling Smorgrav writes: > > > Umm, you can't use opiechallenge() for that. You're not supposed to > > > call opiechallenge() without also calling opieverify() (plus, I think > > > opiechallenge() "consumes" a challenge). Use opielookup() instead. > > > > Even better, opie_haskey() (which is a wrapper around opielookup()). > > New patch attached. > > Yes, this patch works as expected, but I doubt about opie_haskey() status. > It looks like non-standard FreeBSD addition since it is in the local > opieextra.c file and not in contrib/opie. If you care about > machine independance, better use opielookup() directly. No, that is OK. :-) The FreeBSD PAM modules are all written from scratch as BSD PAM modules. M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message