Date: Tue, 9 Jul 2013 08:01:29 -0700 From: Jeremy Chadwick <jdc@koitsu.org> To: Robert Millan <rmh@freebsd.org> Cc: freebsd-fs@freebsd.org Subject: Re: Compatibility options for mount(8) Message-ID: <20130709150129.GA8289@icarus.home.lan> In-Reply-To: <CAOfDtXNxT%2BhnS8n%2BOY6a7n=6UiwgDJo6M3GZx48JgskRKoY=gg@mail.gmail.com> References: <CAOfDtXM_KJeLLUcsFA0EZOC8ZgSjKiLKuGeeNPQKCcZwcaJbCQ@mail.gmail.com> <20130702000732.GA72587@icarus.home.lan> <CAOfDtXNxT%2BhnS8n%2BOY6a7n=6UiwgDJo6M3GZx48JgskRKoY=gg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 09, 2013 at 04:47:46PM +0200, Robert Millan wrote:
> > 2. Please use strncmp(). I know other parts of the same code use strcmp()
> > and those should really be improved at some other time, but while you're
> > already there you might as well use strncmp() (you'll see others have
> > done the same), i.e.:
> >
> > } else if (strncmp(p, "remount", 7) == 0) {
>
> What is the rationale behind this?
Primarily security and stability. I won't get into a discussion about
this as it'll just bikeshed, particularly when there's an almost
indefinite amount of information online about the dangers of strcmp(3).
--
| Jeremy Chadwick jdc@koitsu.org |
| UNIX Systems Administrator http://jdc.koitsu.org/ |
| Making life hard for others since 1977. PGP 4BD6C0CB |
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130709150129.GA8289>