From owner-cvs-src@FreeBSD.ORG Tue Sep 23 15:14:49 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EF5AE1065671; Tue, 23 Sep 2008 15:14:49 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id CF7B98FC20; Tue, 23 Sep 2008 15:14:49 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id m8NFEESM096262; Tue, 23 Sep 2008 08:14:34 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.2/Submit) id m8NFE9Ou096258; Tue, 23 Sep 2008 08:14:09 -0700 (PDT) (envelope-from obrien) Date: Tue, 23 Sep 2008 08:13:53 -0700 From: "David O'Brien" To: Sam Leffler Message-ID: <20080923151353.GC50098@dragon.NUXI.org> References: <200809231446.m8NEkQev007507@repoman.freebsd.org> <48D9038B.3040000@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48D9038B.3040000@freebsd.org> X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/conf files src/sys/fs/tmpfs tmpfs.h tmpfs_subr.c tmpfs_vnops.c src/sys/i386/i386 bios.c src/sys/ia64/ia64 efi.c sal.c src/sys/libkern memcmp.c src/sys/mips/mips support.S src/sys/sys libkern.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2008 15:14:50 -0000 On Tue, Sep 23, 2008 at 07:56:11AM -0700, Sam Leffler wrote: > David E. O'Brien wrote: >> obrien 2008-09-23 14:45:10 UTC >> FreeBSD src repository >> Modified files: >> sys/conf files sys/fs/tmpfs tmpfs.h >> tmpfs_subr.c tmpfs_vnops.c sys/i386/i386 bios.c >> sys/ia64/ia64 efi.c sal.c sys/mips/mips support.S >> sys/sys libkern.h Added files: >> sys/libkern memcmp.c Log: >> SVN rev 183299 on 2008-09-23 14:45:10Z by obrien >> The kernel implemented 'memcmp' is an alias for 'bcmp'. However, >> memcmp >> and bcmp are not the same thing. 'man bcmp' states that the return is >> "non-zero" if the two byte strings are not identical. Where as, >> 'man memcmp' states that the return is the "difference between the >> first two differing bytes (treated as unsigned char values" if the >> two byte strings are not identical. >> So provide a proper memcmp(9), but it is a C implementation not a >> tuned >> assembly implementation. Therefore bcmp(9) should be preferred over >> memcmp(9). >> > Given the performance difference this change should have been reviewed > before dumping it into the tree. > I do not agree with this; You do not agree with fixing a bug in our code? > did you post it somewhere? No. -- -- David (obrien@FreeBSD.org)