From owner-cvs-src@FreeBSD.ORG  Mon Feb 11 23:52:01 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 51E1516A46B;
	Mon, 11 Feb 2008 23:52:01 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219])
	by mx1.freebsd.org (Postfix) with ESMTP id 4DE5813C447;
	Mon, 11 Feb 2008 23:51:59 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (unverified [66.23.211.162]) 
	by speedfactory.net (SurgeMail 3.8s) with ESMTP id 231629584-1834499 
	for multiple; Mon, 11 Feb 2008 18:52:17 -0500
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m1BNpuBR053578;
	Mon, 11 Feb 2008 18:51:56 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: SXren Schmidt <sos@freebsd.org>
Date: Mon, 11 Feb 2008 18:49:44 -0500
User-Agent: KMail/1.9.7
References: <200712131147.lBDBlaFi066300@repoman.freebsd.org>
In-Reply-To: <200712131147.lBDBlaFi066300@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200802111849.44512.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Mon, 11 Feb 2008 18:51:56 -0500 (EST)
X-Virus-Scanned: ClamAV 0.91.2/5779/Mon Feb 11 14:56:48 2008 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/dev/ata ata-all.h ata-chipset.c ata-dma.c
	ata-lowlevel.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2008 23:52:01 -0000

On Thursday 13 December 2007 06:47:36 am SXren Schmidt wrote:
> sos         2007-12-13 11:47:36 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/ata          ata-all.h ata-chipset.c ata-dma.c 
>                          ata-lowlevel.c 
>   Log:
>   Implement a workaround of the datacorruption problem on serverworks HT1000 
chipsets.
>   The HT1000 DMA engine seems to not always like 64K transfers and sometimes 
barfs data all over memory leading to instant chrash and burn.
>   Also fix 48bit adressing issues, apparently newer chips needs 16bit writes 
and not the usual fifo thing.
>   
>   HW donated by: Travis Mikalson at TerraNovaNet

I'm not sure how best to fix it, but it seems that this broke crash dumps on 
the HT1000 chipset:

exit1() at exit1+0x39d
sys_exit() at sys_exit+0xe
ia32_syscall() at ia32_syscall+0x256
Xint0x80_syscall() at Xint0x80_syscall+0x5d
Uptime: 5d0h51m55s
Physical memory: 4084 MB
Dumping 325 MB:ata2: FAILURE - oversized DMA transfer attempt 65536 > 64512
ad4: setting up DMA failed

** DUMP FAILED (ERROR 5) **
Automatic reboot in 15 seconds - press a key on the console to abort
Rebooting...
cpu_reset: Restarting BSP

I'm guessing that the atadev->max_iosize is still set to 64k somehow (DMA 
default) for the ata disk when it does the check in ad_strategy(), but I'm 
not sure how as for the HT1000 chipset at least ch->dma->max_iosize is set to 
63k in the controller allocate routine which should be run before the child 
disk devices are probed and attached AFAICT.

-- 
John Baldwin