From owner-svn-src-all@freebsd.org Mon Apr 11 05:24:05 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AF4EAEC91E; Mon, 11 Apr 2016 05:24:05 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp002.me.com (mr11p00im-asmtp002.me.com [17.110.69.253]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 613951CD5; Mon, 11 Apr 2016 05:24:05 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from [192.168.1.4] (c-50-174-208-73.hsd1.ca.comcast.net [50.174.208.73]) by mr11p00im-asmtp002.me.com (Oracle Communications Messaging Server 7.0.5.36.0 64bit (built Sep 8 2015)) with ESMTPSA id <0O5G00L7XEZYA530@mr11p00im-asmtp002.me.com>; Mon, 11 Apr 2016 05:23:59 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-11_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1510270003 definitions=main-1604110083 User-Agent: Microsoft-MacOutlook/0.0.0.160212 Date: Sun, 10 Apr 2016 22:23:57 -0700 Subject: Re: svn commit: r297802 - head/sys/dev/hyperv/vmbus From: Ravi Pokala Sender: "Pokala, Ravi" To: Sepherosa Ziehau , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: <0FE57290-DFEA-4524-9A46-9532643BB9FA@panasas.com> Thread-topic: svn commit: r297802 - head/sys/dev/hyperv/vmbus References: <201604110328.u3B3SI9e070348@repo.freebsd.org> In-reply-to: <201604110328.u3B3SI9e070348@repo.freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 05:24:05 -0000 Hi sephe, -----Original Message----- From: on behalf of Sepherosa Ziehau Date: 2016-04-10, Sunday at 20:28 To: , , Subject: svn commit: r297802 - head/sys/dev/hyperv/vmbus >Author: sephe >Date: Mon Apr 11 03:28:17 2016 >New Revision: 297802 >URL: https://svnweb.freebsd.org/changeset/base/297802 > >Log: > hyperv: Identify Hyper-V features and recommends properly > > Features bits will be used to detect devices, e.g. timers, which > do not have corresponding event channels. > > ... > >+ op = HV_CPU_ID_FUNCTION_HV_INTERFACE; >+ do_cpuid(op, regs); >+ if (regs[0] != 0x31237648 /* HV#1 */) >+ return (false); Could you make that a #defined constant, rather than a magic integer? Thanks, Ravi (rpokala@)