From owner-cvs-all Sun Jan 12 0:59:54 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 973B837B405; Sun, 12 Jan 2003 00:59:52 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id BBBF443F18; Sun, 12 Jan 2003 00:59:51 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h0C8xZ4x003903; Sun, 12 Jan 2003 09:59:35 +0100 (CET) (envelope-from phk@freebsd.org) To: Matt Dillon Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_acl.c kern_descrip.c kern_event.c kern_mac.c sys_pipe.c sys_socket.c uipc_socket.c uipc_syscalls.c uipc_usrreq.c vfs_aio.c vfs_syscalls.c vfs_vnops.c src/sys/netgraph ng_socket.c src/sys/sys file.h src/sys/ufs/ffs ... From: phk@freebsd.org In-Reply-To: Your message of "Sat, 11 Jan 2003 17:37:13 PST." <200301120137.h0C1bD0E098037@repoman.freebsd.org> Date: Sun, 12 Jan 2003 09:59:35 +0100 Message-ID: <3902.1042361975@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200301120137.h0C1bD0E098037@repoman.freebsd.org>, Matt Dillon write s: > sys/sys file.h > Log: > Change struct file f_data to un_data, a union of the correct struct > pointer types, and remove a huge number of casts from code using it. This change is in the wrong direction: Rather than keep the layering strict, it ruins the layering by not almost but not quite teaching struct file about all the underlying kinds of stuff. With this change we have to modify sys/file.h if we add a new backing for struct file, something which had until now not been necessary. This cost is not offset by the fact that the source code is not any clearer and mostly it hides the simplicity of the object model used. (in the case of sys/file.h it's worse). You could instead just have removed all the unneeded casts, (there may be one or two legitimate ones), but even that is a bad idea at a time where so many people diff between RELENG_5_0 and -current. Please back it out. Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message