From owner-svn-src-all@freebsd.org Fri Jun 10 12:19:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE610AEE10D for ; Fri, 10 Jun 2016 12:19:52 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8B6C81153 for ; Fri, 10 Jun 2016 12:19:52 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f51.google.com with SMTP id q132so7223424lfe.3 for ; Fri, 10 Jun 2016 05:19:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=UGvO5WhYyFvD86x3bUsa0vZTySdIALyO4G91i3U5TRw=; b=K6HwKqBfBp+8RePejdmM+40/HbnWj893eKGWvrRgmaW0w9ZjlzxL6mbobT/9NhReD6 u3S2j47Sh7l1Sigl6mUeRDwaK0ZyhjNtOyWzFlXNkvjztkHANxsvcHZEO7Y7ubV+JQav rMKK/DBpWSFwmOxUKcCDKvDNi/dmwutd0zTbWeKKxGYmrxGkCqL/vNWP5bWqzsgkuo1R jHp0jiNYI8mr29PtDhw4lQDhU/4SdCx8onAkJM3qscf4n5A7oy4I9qQIbEeNrPbZayf4 Rztmdk3TfU+pJuHAqKIj7+2IXiXcKmYpt8AayjHStQnAZ/ECItxFzzXPiW1QLo/sMK1T 1ECw== X-Gm-Message-State: ALyK8tLm0VTi3wHWYY7TpUAd0n7iU48aTvMs1U3mQNkFJ7T9WdE1tsz69XzrlAQYzcI08A== X-Received: by 10.25.139.135 with SMTP id n129mr490323lfd.209.1465561184728; Fri, 10 Jun 2016 05:19:44 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id g82sm1127166ljg.45.2016.06.10.05.19.43 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 10 Jun 2016 05:19:44 -0700 (PDT) Subject: Re: svn commit: r301777 - head/lib/libc/stdio To: Pedro Giffuni , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201606100521.u5A5Lqa6035072@repo.freebsd.org> <3346cab5-d713-c1ad-5e50-ea8d50ee47b9@freebsd.org> From: Andrey Chernov Message-ID: <52d3a4b3-0b52-abd3-8633-909885f12781@freebsd.org> Date: Fri, 10 Jun 2016 15:19:43 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2016 12:19:53 -0000 On 10.06.2016 15:03, Pedro Giffuni wrote: > (Sorry I have been offline/sleep for a while) > > Hello; > > I cannot back this out because of this report: > > http://docs.freebsd.org/cgi/mid.cgi?20160608132224.GA15454 > > This change only re-states what has been working before the ABI breakage > fix in r301461. Because now strcoll_l() is used as before and it is broken in wide char converting process. It is broken for _all_, not just for vfscanf() ranges. It should never fail with any args. Real fix should be in strcoll_l(). > The fix to regex is completely independent. It is dependent. vfscanf() and regcomp() use the same code for range collation. If we remove range collation from everywhere, we save vfscanf(), but strcoll_l() remains broken.