From owner-freebsd-hackers Wed Dec 11 17:44:18 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EBB0937B401 for ; Wed, 11 Dec 2002 17:44:16 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 5A15243EA9 for ; Wed, 11 Dec 2002 17:44:16 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 32171 invoked by uid 1000); 12 Dec 2002 01:44:18 -0000 Date: Wed, 11 Dec 2002 17:44:18 -0800 (PST) From: Nate Lawson To: Ian Dowse Cc: Alexander Langer , Patrick Soltani , freebsd-hackers@FreeBSD.ORG, luigi@FreeBSD.ORG Subject: Re: panic: icmp_error: bad length In-Reply-To: <200212120054.aa55340@salmon.maths.tcd.ie> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 12 Dec 2002, Ian Dowse wrote: > --- ip_fw.c 21 Nov 2002 01:27:30 -0000 1.131.2.38 > +++ ip_fw.c 12 Dec 2002 00:43:22 -0000 > @@ -1573,6 +1573,11 @@ > break; > } > default: /* Send an ICMP unreachable using code */ > + /* Must convert to host order for icmp_error(). */ > + if (BRIDGED) { > + NTOHS(ip->ip_len); > + NTOHS(ip->ip_off); > + } > icmp_error(*m, ICMP_UNREACH, > f->fw_reject_code, 0L, 0); > *m = NULL; Since the REJECT case needs several headers in host order, why not put this there (line 1546), taking care of potential problems in the tcp RST case? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message