Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 29 Nov 2020 02:16:29 +0000 (UTC)
From:      Piotr Kubaj <pkubaj@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r556545 - head/security/openssh-portable
Message-ID:  <202011290216.0AT2GTek031005@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pkubaj
Date: Sun Nov 29 02:16:28 2020
New Revision: 556545
URL: https://svnweb.freebsd.org/changeset/ports/556545

Log:
  security/openssh-portable: fix build on GCC architectures
  
  loginrec.c:763:2: error: 'strncpy' output may be truncated copying 32 bytes from a string of length 511 [-Werror=stringop-truncation]
  strncpy(utx->ut_user, li->username,
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  MIN_SIZEOF(utx->ut_user, li->username));
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  loginrec.c: In function 'record_failed_login':
  loginrec.c:1687:2: error: 'strncpy' specified bound 32 equals destination size [-Werror=stringop-truncation]
  strncpy(ut.ut_user, username, sizeof(ut.ut_user));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  loginrec.c:1696:2: error: 'strncpy' specified bound 256 equals destination size [-Werror=stringop-truncation]
  strncpy(ut.ut_host, hostname, sizeof(ut.ut_host));

Modified:
  head/security/openssh-portable/Makefile

Modified: head/security/openssh-portable/Makefile
==============================================================================
--- head/security/openssh-portable/Makefile	Sun Nov 29 01:00:19 2020	(r556544)
+++ head/security/openssh-portable/Makefile	Sun Nov 29 02:16:28 2020	(r556545)
@@ -19,7 +19,8 @@ LICENSE_PERMS=	dist-mirror dist-sell pkg-mirror pkg-se
 
 CONFLICTS?=		openssh-3.* ssh-1.* ssh2-3.* openssh-portable-devel-*
 
-USES=			alias autoreconf localbase ncurses pkgconfig ssl
+USES=			alias autoreconf compiler:c11 localbase ncurses \
+			pkgconfig ssl
 GNU_CONFIGURE=		yes
 CONFIGURE_ARGS=		--prefix=${PREFIX} \
 			--with-ssl-engine \
@@ -185,6 +186,9 @@ CONFIGURE_ARGS+=	--with-xauth=${LOCALBASE}/bin/xauth
 
 RC_SCRIPT_NAME=		openssh
 VERSION_ADDENDUM_DEFAULT?=	${OPSYS}-${PKGNAME}
+
+CFLAGS+=	${CFLAGS_${CHOSEN_COMPILER_TYPE}}
+CFLAGS_gcc=	-Wno-stringop-truncation
 
 post-patch:
 	@${REINPLACE_CMD} \



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011290216.0AT2GTek031005>