From owner-svn-ports-head@freebsd.org  Wed Feb 27 15:34:59 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08FE3151FBB2;
 Wed, 27 Feb 2019 15:34:59 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A28A88321F;
 Wed, 27 Feb 2019 15:34:58 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 800E41A0A1; Wed, 27 Feb 2019 15:34:58 +0000 (UTC)
Date: Wed, 27 Feb 2019 15:34:58 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Cy Schubert <Cy.Schubert@cschubert.com>
Cc: Niclas Zeising <zeising@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r494049 - in head/devel/imake: . files
Message-ID: <20190227153458.GA57893@FreeBSD.org>
References: <201902271255.x1RCtIJs066388@repo.freebsd.org>
 <20190227131242.GA6386@FreeBSD.org>
 <FF1C3C24-3E8B-4B94-AB7C-212B3C0CE661@cschubert.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <FF1C3C24-3E8B-4B94-AB7C-212B3C0CE661@cschubert.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: A28A88321F
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.92 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[];
 NEURAL_HAM_SHORT(-0.92)[-0.919,0]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Feb 2019 15:34:59 -0000

On Wed, Feb 27, 2019 at 06:53:10AM -0800, Cy Schubert wrote:
> Making unrelated changes in the same commit, even when documented, makes
> parsing of the patch necessary for those who might need to analyze a patch
> months after the fact.

Of course.  But in this case it was so obviously wrong that I kindly want
to remind all of us that tidy commit history is essential to work with our
code and ports efficiently, and "svn st" with "svn diff" prior to commit
can save us from making this silly mistakes.

./danfe