From owner-freebsd-current Mon Jun 8 13:12:25 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA25316 for freebsd-current-outgoing; Mon, 8 Jun 1998 13:12:25 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from dingo.cdrom.com (dingo.cdrom.com [204.216.28.145]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA25191 for ; Mon, 8 Jun 1998 13:12:18 -0700 (PDT) (envelope-from mike@dingo.cdrom.com) Received: from dingo.cdrom.com (localhost [127.0.0.1]) by dingo.cdrom.com (8.8.8/8.8.5) with ESMTP id MAA00529; Mon, 8 Jun 1998 12:05:23 -0700 (PDT) Message-Id: <199806081905.MAA00529@dingo.cdrom.com> X-Mailer: exmh version 2.0zeta 7/24/97 To: Terry Lambert cc: wjw@IAEhv.nl, winter@jurai.net, mike@smith.net.au, current@FreeBSD.ORG Subject: Re: Variant Link implementation (Was: Re: lorder problem: ....... ) In-reply-to: Your message of "Mon, 08 Jun 1998 18:12:04 -0000." <199806081812.LAA11746@usr04.primenet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 08 Jun 1998 12:05:22 -0700 From: Mike Smith Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > => > Whoops; just to clarify; vlink_xlate(tok, dbuf, &dbofs) copies the > > => > value of the token at (tok) into (dbuf) at (dbofs) presuming that > > => > (dbofs) would not exceed the allowed size, updates (dbofs) and returns > > => > 0 (all OK), 1 (not enough room) or 2 (no translation for tok available). > > => > > => Would it not be nicer to introduce a new file/link type? This would allow > > => lower overall cost as you would not have to scan each link, only those > > => links of the proper type. > > > > That's one way of doing it. Is was first thinking of doing it through sysctl > > for the whole system on or off. But then that is a sort of blunt axe > > solution. > > A new link type is overkill. The evaluation of symlinks uses FORTRAN-style > mutual recursion (into the same buffer) anyway. > > The speed of symlink evaluation isn't really an issue unless the "${" / "}" > is found to be there anyway (or shouldn't be). > > It seems to me that the code Mike did fails on the "${" but NOT "}" case. It shouldn't; if it doesn't find the '}' it should fall off the end, copy the $ and try again. I didn't want to abort on a separator because it would cause eg. this to not work: bin$ -> bin.${DOS/Win version} -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message