From owner-freebsd-x11@FreeBSD.ORG Wed Nov 18 00:50:24 2009 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13D11106566B; Wed, 18 Nov 2009 00:50:24 +0000 (UTC) (envelope-from unixmania@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by mx1.freebsd.org (Postfix) with ESMTP id 742DD8FC25; Wed, 18 Nov 2009 00:50:23 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id d23so269432fga.13 for ; Tue, 17 Nov 2009 16:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ufVYAmiY2bEqLaGKpGjBxrvKIjODpu/o0je3DKSYVRs=; b=qFOByzikM1rS5FEnTVYoisQSk6d3wNCeGD1tVoyS/wm/cV/xSShzbIca9KvGwpG1KB g+pvXwaHkawtZ1XRcOwc0JW2Q0Nq0JPtmW9QJ0ipyXTycyeQl1sjP6YDGuCzMKMmaTNA 4NBhZpvXGpNnXe6EeYQEb1jW0pwT6UEQq0TFw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=kZ/KzL5nGYITn/XGosziHSBNeqrMSZodQLD8koF/RFhwRJs3/VTPhvwbNJmEpNHWd7 8j+I+WDu0rJgIfSG1cAlv89e0qJ7TR7f0WzNAWavQMU3+QqAtgFErZE1nX0y/UHj5l6E Yykk72Zefra1t4nAiHxqJyQqP3V2sMeQWXuiE= MIME-Version: 1.0 Received: by 10.239.168.166 with SMTP id k38mr977539hbe.63.1258505422251; Tue, 17 Nov 2009 16:50:22 -0800 (PST) In-Reply-To: <19203.4505.30354.388990@gromit.timing.com> References: <200911170210.nAH2A3B2089193@freefall.freebsd.org> <1258477653.2303.48.camel@balrog.2hip.net> <19203.4505.30354.388990@gromit.timing.com> Date: Tue, 17 Nov 2009 22:50:22 -0200 Message-ID: From: "Carlos A. M. dos Santos" To: John Hein Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-x11@freebsd.org Subject: Re: ports/137373: x11/libX11: make dependance on x11/libxcb X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2009 00:50:24 -0000 On Tue, Nov 17, 2009 at 7:11 PM, John Hein wrote: > Carlos A. M. dos Santos wrote at 18:22 -0200 on Nov 17, 2009: > =A0> On Tue, Nov 17, 2009 at 3:07 PM, Robert Noland = wrote: > =A0> > There is a pretty fair risk of breaking several other ports with t= his. > =A0> > Other ports that also expect xcb to be present would need to be mo= dified > =A0> > to either have xcb disabled or fail if libX11 does not have the ne= eded > =A0> > functionality. > =A0> > =A0> That's exactly why I made it optional, default on, keeping the > =A0> default behavior. > > I think that what Robert may be saying is that even if it's default is > 'on', people will turn it off, and we might see lots of questions > about why this port or that port isn't working. If such reasoning had any value then you should start removing all the options on all ports right now. Run! > Maybe you can investigate a few ports that may need the xcb-ness > of libX11 and see what it takes to make them work in an xcb-free > flavor of libX11 (or hint at build time that they won't work > if libX11 doesn't have xcb). Ports that explicitly require xcb must do it via *DEPENDS in their respective makefiles, not by means of some under-the-hood dependency via libX11, which is an error. > The alternative is to commit this change and just see what breaks. Ports that break are already broken and must be fixed. Of course we can pretend they are not broken and keep going, but that would be a shame. > But doing a little investigation ahead of time to give us a heads up > about what to expect would be useful. Simply put, turn off the dependency of libX11 on libxcb. Then mark libxb as FORBIDDEN and rebuild all packages that depend on libX11. Any port whose build breaks is ... well, broken. --=20 My preferred quotation of Robert Louis Stevenson is "You cannot make an omelette without breaking eggs". Not because I like the omelettes, but because I like the sound of eggs being broken.