From owner-svn-src-all@FreeBSD.ORG  Fri Jul  5 01:28:30 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id CE5DC3A4;
 Fri,  5 Jul 2013 01:28:30 +0000 (UTC)
 (envelope-from dteske@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id C09A718BC;
 Fri,  5 Jul 2013 01:28:30 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r651SU6r024927;
 Fri, 5 Jul 2013 01:28:30 GMT (envelope-from dteske@svn.freebsd.org)
Received: (from dteske@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r651SUcA024926;
 Fri, 5 Jul 2013 01:28:30 GMT (envelope-from dteske@svn.freebsd.org)
Message-Id: <201307050128.r651SUcA024926@svn.freebsd.org>
From: Devin Teske <dteske@FreeBSD.org>
Date: Fri, 5 Jul 2013 01:28:30 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r252740 - head/usr.sbin/bsdconfig/share/packages
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Jul 2013 01:28:30 -0000

Author: dteske
Date: Fri Jul  5 01:28:30 2013
New Revision: 252740
URL: http://svnweb.freebsd.org/changeset/base/252740

Log:
  Comments.

Modified:
  head/usr.sbin/bsdconfig/share/packages/packages.subr

Modified: head/usr.sbin/bsdconfig/share/packages/packages.subr
==============================================================================
--- head/usr.sbin/bsdconfig/share/packages/packages.subr	Fri Jul  5 01:22:37 2013	(r252739)
+++ head/usr.sbin/bsdconfig/share/packages/packages.subr	Fri Jul  5 01:28:30 2013	(r252740)
@@ -48,8 +48,11 @@ f_include_lang $BSDCFG_LIBE/include/mess
 
 ############################################################ GLOBALS
 
-PACKAGE_CATEGORIES=
-SELECTED_PACKAGES=
+#
+# Variables used to track runtime states
+#
+PACKAGE_CATEGORIES=	# List of package categories parsed from INDEX
+SELECTED_PACKAGES=	# Packages selected by user in [X]dialog(1) interface
 
 #
 # Options
@@ -157,6 +160,15 @@ f_package_deselect()
 f_package_detect_installed()
 {
 	local installed package varpkg
+	#
+	# XXX KLUDGE ALERT! This makes evil assumptions about how XXX
+	# packages register themselves and should *really* be done with
+	# `pkg_info -e <name>' except that this is too slow for an
+	# item check routine.. :-(
+	#
+	# NOTE: When transitioning to pkgng, make a single fork to `pkg' to
+	#       produce a list of all installed packages and parse _that_
+	#
 	installed=$( find -s /var/db/pkg -mindepth 1 -maxdepth 1 -type d |
 			sed -e 's:/var/db/pkg/::' )
 	for package in $installed; do