Date: Thu, 6 Sep 2018 13:30:03 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r479028 - head/games/yadex Message-ID: <20180906133003.GA14967@FreeBSD.org> In-Reply-To: <20180905214947.3msj2lkffek66vbo@atuin.in.mat.cc> References: <201809051631.w85GVdwR029041@repo.freebsd.org> <20180905214947.3msj2lkffek66vbo@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 05, 2018 at 11:49:47PM +0200, Mathieu Arnold wrote: > On Wed, Sep 05, 2018 at 04:31:39PM +0000, Alexey Dokuchaev wrote: > > New Revision: 479028 > > URL: https://svnweb.freebsd.org/changeset/ports/479028 > > > > Log: > > Consummate conversion to option helpers (should've been part of r479022). > > > > Modified: head/games/yadex/Makefile > > @@ -37,17 +37,10 @@ PATCH_SUFFIX= .diff > > PATCHFILES= ${PATCH_PREFIX}_Depend${PATCH_SUFFIX} > > > > 3D_RENDER_PATCHFILES= ${PATCH_PREFIX}_Render3D${PATCH_SUFFIX} > > +3D_RENDER_PORTDOCS= preview.html > > This is missing a 3D_RENDER_IMPLIES=DOCS. I don't think so, why? One of the nice things about PORTDOCS that is can (and should) be set unconditionally (independent of DOCS). In fact, I could have simply got away with PORTDOCS=* but I prefer to avoid globbing. If you build the package with OPTIONS_UNSET=DOCS and OPTIONS_DEFAULT= 3D_RENDER you'll see that the package is generated correctly (without the docfiles). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180906133003.GA14967>