From owner-svn-src-all@FreeBSD.ORG Mon Jan 23 11:10:11 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A958F106567D; Mon, 23 Jan 2012 11:10:11 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 860558FC17; Mon, 23 Jan 2012 11:10:10 +0000 (UTC) Received: by lagv3 with SMTP id v3so867668lag.13 for ; Mon, 23 Jan 2012 03:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:x-gm-message-state :content-type:content-transfer-encoding; bh=g47UfsS3A1cTA9KSU15bLBPBKajIdgCotuiiV6qoPnE=; b=sic2L9734SgMKQnVmqr77LHuvUD0nqj4tdEfLEMyMwG3nqlnfAZ5vSfbucBU7Z4bEk OGQ24/6c8NonyNiKS7WnjmzUBjXlHeDCrJSSh76v6Zab+miWCNEKG+lxvO6vzg48r2ib ZL9GgQFSUBYif/QYtyb5eWepb9GlRl7DiFEPs= Received: by 10.112.82.226 with SMTP id l2mr2038608lby.102.1327317009206; Mon, 23 Jan 2012 03:10:09 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.196 with HTTP; Mon, 23 Jan 2012 03:09:37 -0800 (PST) In-Reply-To: <20120123.132840.618925004528110765.hrs@allbsd.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120123.132840.618925004528110765.hrs@allbsd.org> From: Eitan Adler Date: Mon, 23 Jan 2012 06:09:37 -0500 X-Google-Sender-Auth: 4lL3GDt_hGy73Lq6D3XYkebIitQ Message-ID: To: Hiroki Sato X-Gm-Message-State: ALoCoQlt5AV9MzJiWQcfwTnY6QA/GN0rXV0aGqFdXHjDf9xwSgdvSVvjjQCFGzy0wOgedkvV3wrv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 11:10:11 -0000 On Sun, Jan 22, 2012 at 11:28 PM, Hiroki Sato wrote: > ea> bug fix which could be upstreamed that would be great. On the other > ea> hand I would like to continue with my goal of making the non-contrib > ea> world compilable with CC=3Dgcc46. > ea> > ea> Should I revert this commit? > > =C2=A0I don't think it is needed. =C2=A0The makefs utility is a special c= ase > =C2=A0because it will probably diverge from the upstream to support > =C2=A0FreeBSD-specific feature in the future (this is one of the reasons > =C2=A0why it is not in contrib/). =C2=A0It didn't happen so far, however. Understood. > =C2=A0By the way, does gcc46 no longer allow unused code? gcc46 enables -Wunused-but-set-variable enabled with -Wextra. One possible solution is to just disable the warning, but IMHO having random unused variables just makes code harder to understand. It also enables a few other stricter checks for C conformance. > Generally speaking, I think it is enough to clean up unused code only whe= n we > =C2=A0actually change the code. If these were style(9) or "best practice" cleanups - I'd agree. However this was prompted by my specific goal of making the userland code compile with gcc46. It would be nice to see FreeBSD as compiler agnostic as possible. --=20 Eitan Adler Source & Ports committer X11, Bugbusting teams