From owner-svn-src-all@FreeBSD.ORG Mon Jan 7 15:14:57 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 5602C502; Mon, 7 Jan 2013 15:14:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 318AFFB3; Mon, 7 Jan 2013 15:14:57 +0000 (UTC) Received: from ralph.baldwin.cx (c-68-39-198-164.hsd1.de.comcast.net [68.39.198.164]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4A14BB91A; Mon, 7 Jan 2013 10:14:56 -0500 (EST) From: John Baldwin To: Jaakko Heinonen Subject: Re: svn commit: r244585 - in head: . sys/geom/label Date: Mon, 7 Jan 2013 09:27:06 -0500 User-Agent: KMail/1.13.7 (FreeBSD/9.1-PRERELEASE; KDE/4.8.4; amd64; ; ) References: <201212221343.qBMDhCHa086834@svn.freebsd.org> <201301041218.07804.john@baldwin.cx> <20130105092252.GA1832@a91-153-116-96.elisa-laajakaista.fi> In-Reply-To: <20130105092252.GA1832@a91-153-116-96.elisa-laajakaista.fi> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201301070927.07157.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 07 Jan 2013 10:14:56 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2013 15:14:57 -0000 On Saturday, January 05, 2013 04:22:52 AM Jaakko Heinonen wrote: > On 2013-01-04, John Baldwin wrote: > > > New Revision: 244585 > > > > > > Log: > > > Mangle label names containing spaces, non-printable characters '%' or > > > '"'. Mangling is only done for label names read from file system > > > metadata. Encoding resembles URL encoding. For example, the space > > > character becomes %20. > > > > Ouch, mangling spaces seems unfortunate. I guess fixing the devctl > > protocol is too hard, and/or we can't just encode it at the protocol > > layer but leave the actual device names untouched? > > I initially proposed changing the devctl protocol but in a private > discussion people preferred to not change the protocol. However, I think > that allowing the space character only might be possible without > changing the protocol as devd(8) can already handle strings enclosed in > double quotes. usb(4) already uses such devctl variables. > > > OS X preserves spaces in volume names and those can be quite common on > > ISO images, so mangling them really does seem to be a shame if we can > > avoid it. > > How important do you think this is? I understand that it's annoyance for > people upgrading their systems but labels with spaces can still be used. I think if it isn't hard to do so, we should aim to preserve labels as they are generally intended to be human readable as-is. Just preserving spaces is probably sufficient for this as they are probably the most commonly used character in labels affected by this change. -- John Baldwin