From owner-svn-src-all@FreeBSD.ORG Tue Aug 4 08:26:50 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA636106566B; Tue, 4 Aug 2009 08:26:50 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id A38FB8FC17; Tue, 4 Aug 2009 08:26:50 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTPS id 6473D46B09; Tue, 4 Aug 2009 04:26:49 -0400 (EDT) Date: Tue, 4 Aug 2009 09:26:49 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Bruce Simpson In-Reply-To: <4A77E9F1.6040407@incunabulum.net> Message-ID: References: <200908021943.n72JhWKX023102@svn.freebsd.org> <4A77E9F1.6040407@incunabulum.net> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196039 - in head/sys: contrib/pf/net dev/cxgb/ulp/tom net netinet netinet6 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2009 08:26:51 -0000 On Tue, 4 Aug 2009, Bruce Simpson wrote: > I didn't see any changes which directly touched ip_mroute in this rev. Can > you clarify how this touches ip_mroute? It wasn't obvious from the diff. You're right, it was included in error. ip_mroute is on the list of modules that uses a stats structure with an accessor macro, but that structure make it onto the list of structures requiring accessor functions because it's accessed only from within ip_mroute (actually, two such functions/macros). I must have made a transcription error when writing up the commit message. My notes on accessor macros and files that consume them below. Robert Defined Used ------- ---- ICMPSTAT_ADD icmp_var.h icmp_var.h ICMPSTAT_INC icmp_var.h ip_icmp.c, *pf.c IGMPSTAT_ADD igmp_var.h igmp_var.h IGMPSTAT_INC igmp_var.h igmp.c MRTSTAT_ADD ip_mroute.h ip_mroute.h MRTSTAT_INC ip_mroute.h *ip_mroute.c IPSTAT_ADD ip_var.h ip_var.h, ip_output.c, IPSTAT_SUB ip_var.h ip_var.h IPSTAT_INC ip_var.h raw_ip.c, *ip_divert.c, ip_output.c, ip_input.c, ip_ipsec.c, *in_gif.c, igmp.c, ip_options.c, ip_fastfwd.c, udp_usrreq.c, *if_bridge.c, *pf.c, ip_var.h IPSTAT_DEC ip_var.h raw_ip.c, *ip_divert.c, ip_var.h PIMSTAT_ADD pim_var.h *ip_mroute.c, pim_var.h PIMSTAT_INC pim_var.h *ip_mroute.c UDPSTAT_ADD udp_var.h udp_var.h UDPSTAT_INC udp_var.h udp_usrreq.c, udp6_usrreq.c, *pf.c TCPSTAT_ADD tcp_var.h tcp_input.c, tcp_reass.c, tcp_output.c, tcp_var.h TCPSTAT_INC tcp_var.h tcp_input.c, tcp_subr.c, tcp_reass.c, tcp_timer.c, tcp_sack.c, tcp_output.c, tcp_hostcache.c, tcp_syncache.c, tcp_usrreq.c, tcp_timewait.c, *cxgb_cpl_io.c, *pf.c IP6STAT_ADD ip6_var.h ip6_var.h IP6STAT_SUB ip6_var.h ip6_var.h IP6STAT_INC ip6_var.h raw_ip6.c, icmp6.c, udp6_usrreq.c, mld6.c, ip6_input.c IP6STAT_DEC ip6_var.h icmp6.c CARPSTATS_ADD ip_carp.h ip_carp.h CARPSTATS_INC ip_carp.h ip_carp.c ICMP6STAT_ADD icmp6.h icmp6.h ICMP6STAT_INC icmp6.h raw_ip6.c icmp6.c nd6.c nd6_nbr.c mld6.c nd6_rtr.c *pf.c * Files that are built into kernel modules. Things that use things they shouldn't: pf.c: ICMPSTAT_INC, IPSTAT_INC, UDPSTAT_INC, TCPSTAT_INC ip_divert.c: IPSTAT_INC, IPSTAT_DEC in_gif.c: IPSTAT_INC if_bridge.c: IPSTAT_INC cxgb_cpl_io.c: TCPSTAT_INC