From owner-cvs-src@FreeBSD.ORG  Sun Feb 12 12:34:14 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 900ED16A420;
	Sun, 12 Feb 2006 12:34:14 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 04FC043D66;
	Sun, 12 Feb 2006 12:34:13 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id A4A6246C39;
	Sun, 12 Feb 2006 07:34:00 -0500 (EST)
Date: Sun, 12 Feb 2006 12:37:07 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Attila Nagy <bra@fsn.hu>
In-Reply-To: <43EF2A06.3000405@fsn.hu>
Message-ID: <20060212123623.E71792@fledge.watson.org>
References: <200602112109.k1BL9RDk001860@repoman.freebsd.org>
	<43EF2A06.3000405@fsn.hu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ufs ufs_quota.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Feb 2006 12:34:14 -0000

On Sun, 12 Feb 2006, Attila Nagy wrote:

> Robert Watson wrote:
>>   Modified files:
>>     sys/ufs/ufs          ufs_quota.c   Log:
>>   Instead of asserting the vnode lock before manipulating v_vflag, acquire
>>   it and drop it afterwards.
>>     Found by:       kris
>>   MFC after:      1 week
>>     Revision  Changes    Path
>>   1.78      +2 -1      src/sys/ufs/ufs/ufs_quota.c
> Any chance that it will fix the following:
> http://marc.theaimsgroup.com/?l=freebsd-amd64&m=113143942917925&w=2
>
> (I will try, but that takes about 5 hours for me to trigger and I cannot 
> reach that machine now)

It's unlikely this change will directly affect that problem; however, Kris ran 
into it while starting stress testing on the quota code in order to try to 
track down that problem, so it is related.

Robert N M Watson