From owner-freebsd-ports@FreeBSD.ORG  Sun Dec 28 17:06:04 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA8B81065673;
	Sun, 28 Dec 2008 17:06:04 +0000 (UTC)
	(envelope-from eitanadlerlist@gmail.com)
Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.173])
	by mx1.freebsd.org (Postfix) with ESMTP id A17C18FC17;
	Sun, 28 Dec 2008 17:06:04 +0000 (UTC)
	(envelope-from eitanadlerlist@gmail.com)
Received: by wf-out-1314.google.com with SMTP id 24so6551998wfg.7
	for <multiple recipients>; Sun, 28 Dec 2008 09:06:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id
	:disposition-notification-to:date:from:reply-to:user-agent
	:mime-version:to:cc:subject:x-enigmail-version:openpgp:content-type
	:content-transfer-encoding;
	bh=CFDvUIvZ7476iz5/9EoEackWikEpdHcn7atRl6S3oZw=;
	b=eF2YVb8/1bnKK9wyn6cXY+OixYs9+Z8SGdIkEmlBJG6A6IezOnhIBJsRwIEITTtCaL
	e6fR91sEYHtGlDi2o2tkUTfDp9AdH5FLdYPrVnPQ4BLmTCaPsl11RjfZrOeMWLNAoLdC
	+5xTpgCEjn4xVOsp17VGQx5ukgNJ7HVAoTbjc=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:disposition-notification-to:date:from:reply-to
	:user-agent:mime-version:to:cc:subject:x-enigmail-version:openpgp
	:content-type:content-transfer-encoding;
	b=dvP/fDSZimRUDSQ2P66JV9g+XvNU6cmgV+VnbtJ5N/pJmvSCYlIjEfy+uMAuVYVfnW
	JmnPOD58JbpkFTvOXmlAlyA8SrLV0HCVmimXKhZ197qs7FEjYuS2IUHyQ893Whei6BsJ
	ogEVisl/AocdR+vYEjHC/5vNZc/4I2IiZm72U=
Received: by 10.142.90.15 with SMTP id n15mr3632975wfb.115.1230483964373;
	Sun, 28 Dec 2008 09:06:04 -0800 (PST)
Received: from aargh.lan (ool-182fcc8b.dyn.optonline.net [24.47.204.139])
	by mx.google.com with ESMTPS id 30sm28510079wfg.45.2008.12.28.09.06.02
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Sun, 28 Dec 2008 09:06:03 -0800 (PST)
Message-ID: <4957B1E5.3030305@gmail.com>
Date: Sun, 28 Dec 2008 12:05:41 -0500
From: Eitan Adler <eitanadlerlist@gmail.com>
User-Agent: Mozilla (X11; U; FreeBSD i386; en-US;
	) Gecko Thunderbird Mnenhy/0.7.5.666
MIME-Version: 1.0
To: "ports@freebsd.org" <ports@freebsd.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=E9C2CCD1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: gnome@freebsd.org
Subject: thunderbird port - a few issues
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: "ports@freebsd.org" <ports@freebsd.org>
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2008 17:06:05 -0000

WANT_GNOME= yes
should that be WANT_GNOME or WITH_GNOME?

We should add --disable-tests to MOZ_OPTIONS unless WITH_DEBUG is enabled.

Lastly:
$portlint
WARN: Makefile: [45]: use of != in assignments is almost never a good
thing to do.  Try to avoid using them.  See
http://lists.freebsd.org/pipermail/freebsd-ports/2008-July/049777.html
for some helpful hints on what to do instead.
could

GECKO_PTHREAD_LIBS!=${CC} -dumpspecs | ${GREP} pthread | ${SED} -e
's|^.*%{\!pg: %{pthread:|| ; s|}.*$$||' || ${TRUE}

be rewritten ?