Date: Thu, 20 Apr 2023 18:18:53 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Hans Petter Selasky <hselasky@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: bb8e8e230d94 - main - Revert "libc: Implement bsort(3) a bitonic type of sorting algorithm." Message-ID: <145FD575-5987-4BD8-805D-26DB13EBF06A@freebsd.org> In-Reply-To: <202304201717.33KHHJsQ044448@gitrepo.freebsd.org> References: <202304201717.33KHHJsQ044448@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 Apr 2023, at 18:17, Hans Petter Selasky <hselasky@FreeBSD.org> = wrote: >=20 > The branch main has been updated by hselasky: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbb8e8e230d94c9522bd9ff95c13dc9f5= b1592929 >=20 > commit bb8e8e230d94c9522bd9ff95c13dc9f5b1592929 > Author: Hans Petter Selasky <hselasky@FreeBSD.org> > AuthorDate: 2023-04-20 16:50:32 +0000 > Commit: Hans Petter Selasky <hselasky@FreeBSD.org> > CommitDate: 2023-04-20 17:16:14 +0000 >=20 > Revert "libc: Implement bsort(3) a bitonic type of sorting = algorithm." >=20 > Some points for the future: > - libc is not the right place for sorting algorithms. > Probably libutil is better suited for this purpose or > a dedicated libsort. Should move all sorting algorithms > away from libc eventually. qsort is part of ISO C, so no. > - CheriBSD uses capabilities for memory access, and could > benefit from a standard memswap() function. > - Do something about qsort() in FreeBSD's libc like: > - Mark it deprecated on FreeBSD, as a first step, > due to missing limits on CPU time. Nobody=E2=80=99s saying that, quite the opposite. It=E2=80=99s in ISO C. > - Audit the use of qsort() in the FreeBSD base system > and consider swapping to other existing sorting > algorithms. No. We=E2=80=99re saying to make the implementation better. Jess > Discussed with: brooks@ >=20 > Differential Revision: https://reviews.freebsd.org/D36493 >=20 > This reverts commit a7469c9c0a504a5e6e9b89e148cd78df5e67ff7f. > This reverts commit 7d65a450cdcc7cc743f2ecd114ba3428a21c0033. > This reverts commit 8dcf3a82c54cb216df3213a013047907636a01da.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?145FD575-5987-4BD8-805D-26DB13EBF06A>