From owner-freebsd-current Tue Aug 25 05:11:13 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA19317 for freebsd-current-outgoing; Tue, 25 Aug 1998 05:11:13 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from ren.dtir.qld.gov.au (ns.dtir.qld.gov.au [203.108.138.66]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA19307 for ; Tue, 25 Aug 1998 05:11:08 -0700 (PDT) (envelope-from syssgm@dtir.qld.gov.au) Received: by ren.dtir.qld.gov.au; id WAA12678; Tue, 25 Aug 1998 22:10:23 +1000 (EST) Received: from ogre.dtir.qld.gov.au(167.123.8.3) by ren.dtir.qld.gov.au via smap (3.2) id xma012675; Tue, 25 Aug 98 22:10:08 +1000 Received: from atlas.dtir.qld.gov.au (atlas.dtir.qld.gov.au [167.123.8.9]) by ogre.dtir.qld.gov.au (8.8.8/8.8.7) with ESMTP id WAA07290; Tue, 25 Aug 1998 22:10:08 +1000 (EST) Received: from nymph.dtir.qld.gov.au (nymph.dtir.qld.gov.au [167.123.10.10]) by atlas.dtir.qld.gov.au (8.8.5/8.8.5) with ESMTP id WAA18848; Tue, 25 Aug 1998 22:10:07 +1000 (EST) Received: from nymph.dtir.qld.gov.au (localhost.dtir.qld.gov.au [127.0.0.1]) by nymph.dtir.qld.gov.au (8.8.8/8.8.7) with ESMTP id WAA12649; Tue, 25 Aug 1998 22:10:05 +1000 (EST) (envelope-from syssgm@nymph.dtir.qld.gov.au) Message-Id: <199808251210.WAA12649@nymph.dtir.qld.gov.au> To: Doug Rabson cc: "John S. Dyson" , freebsd-current@FreeBSD.ORG, syssgm@dtir.qld.gov.au Subject: Re: Serious bug in vm_page.h in current References: In-Reply-To: from Doug Rabson at "Tue, 25 Aug 1998 10:11:36 +0100" Date: Tue, 25 Aug 1998 22:10:05 +1000 From: Stephen McKay Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tuesday, 25th August 1998, Doug Rabson wrote: >I understand now after reading an old version of your VM patch. I added >the macro PAGE_BUSY to encapsulate manipulations of m->busy and you added >PAGE_BUSY to set the PG_BUSY bit. I think we need two macros :-). I don't >mind changing the m->busy++ one; what do you think is the right name? Purely on naming now, the new inline vm_object_set_flag() and friends are well named. The PAGE_BUSY and PAGE_WAKEUP macros, etc, should be similarly named inline functions. For example, vm_page_busy_add() and vm_page_wakeup(). Best of all, of course, would be to have different names for these two types of busy-ness (busy the count vs PG_BUSY the flag). John tells us that m->busy is an "active IO count". It should be named thus. Then PG_BUSY will no longer be confused with it. Stephen. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message