Date: Fri, 19 Nov 2010 09:35:06 GMT From: Alexander Hausner <alex@hugo.bmg.gv.at> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/152397: [maintainer update] syntax error in ifdepd startscript Message-ID: <201011190935.oAJ9Z6Ag017569@www.freebsd.org> Resent-Message-ID: <201011190940.oAJ9eARJ013142@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 152397
>Category: ports
>Synopsis: [maintainer update] syntax error in ifdepd startscript
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Fri Nov 19 09:40:10 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Alexander Hausner
>Release: 8.1-RELEASE-p1
>Organization:
BMG
>Environment:
FreeBSD hannes.bmgf.gv.at 8.1-RELEASE-p1 FreeBSD 8.1-RELEASE-p1 #17: Wed Sep 22 09:19:49 CEST 2010 root@hannes.bmgf.gv.at:/usr/obj/usr/src/sys/HANNES amd64
>Description:
There is a syntax error in the ifdepd startscript (/usr/local/etc/rc.d/ifdepd) line 39 (39: Syntax error: Unterminated quoted string)
ifdepd_enable=${ifdepd_enable:"NO"} should be
ifdepd_enable=${ifdepd_enable:-"NO"}
Thanks to Arjan van der Oest for spotting this.
>How-To-Repeat:
see "Full Description"
>Fix:
diff -ruN ifdepd.old/files/ifdepd.in ifdepd/files/ifdepd.in
--- ifdepd.old/files/ifdepd.in 2010-05-03 10:52:58.057720000 +0200
+++ ifdepd/files/ifdepd.in 2010-11-19 10:10:54.185505101 +0100
@@ -36,6 +36,6 @@
load_rc_config $name
-ifdepd_enable=${ifdepd_enable:"NO"}
+ifdepd_enable=${ifdepd_enable:-"NO"}
run_rc_command "$1"
Patch attached with submission follows:
diff -ruN ifdepd.old/files/ifdepd.in ifdepd/files/ifdepd.in
--- ifdepd.old/files/ifdepd.in 2010-05-03 10:52:58.057720000 +0200
+++ ifdepd/files/ifdepd.in 2010-11-19 10:10:54.185505101 +0100
@@ -36,6 +36,6 @@
load_rc_config $name
-ifdepd_enable=${ifdepd_enable:"NO"}
+ifdepd_enable=${ifdepd_enable:-"NO"}
run_rc_command "$1"
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011190935.oAJ9Z6Ag017569>