Date: Sat, 9 Aug 2008 11:54:28 GMT From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 146980 for review Message-ID: <200808091154.m79BsSmN064899@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=146980 Change 146980 by trasz@trasz_traszkan on 2008/08/09 11:54:02 Style fixes. Affected files ... .. //depot/projects/soc2008/trasz_nfs4acl/sys/kern/vfs_acl.c#8 edit Differences ... ==== //depot/projects/soc2008/trasz_nfs4acl/sys/kern/vfs_acl.c#8 (text+ko) ==== @@ -133,7 +133,7 @@ case ACL_TYPE_ACCESS_OLD: case ACL_TYPE_DEFAULT_OLD: error = copyin(user_acl, &old, sizeof(struct oldacl)); - if (error) + if (error != 0) break; error = acl_copy_oldacl_into_acl(&old, kernel_acl); break; @@ -155,7 +155,7 @@ case ACL_TYPE_ACCESS_OLD: case ACL_TYPE_DEFAULT_OLD: error = acl_copy_acl_into_oldacl(kernel_acl, &old); - if (error) + if (error != 0) break; error = copyout(&old, user_acl, sizeof(struct oldacl)); @@ -204,7 +204,7 @@ inkernelacl = uma_zalloc(acl_zone, M_WAITOK); error = copyin_acl(aclp, inkernelacl, type); - if (error) + if (error != 0) goto out_free; error = vn_start_write(vp, &mp, V_WAIT | PCATCH); if (error != 0) @@ -270,13 +270,13 @@ int error; error = vn_start_write(vp, &mp, V_WAIT | PCATCH); - if (error) + if (error != 0) return (error); VOP_LEASE(vp, td, td->td_ucred, LEASE_WRITE); vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); #ifdef MAC error = mac_vnode_check_deleteacl(td->td_ucred, vp, type); - if (error) + if (error != 0) goto out; #endif error = VOP_SETACL(vp, type_unold(type), 0, td->td_ucred, td); @@ -300,7 +300,7 @@ inkernelacl = uma_zalloc(acl_zone, M_WAITOK); error = copyin_acl(aclp, inkernelacl, type); - if (error) + if (error != 0) goto out_free; error = VOP_ACLCHECK(vp, type_unold(type), inkernelacl, td->td_ucred, td);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808091154.m79BsSmN064899>