From owner-freebsd-net@FreeBSD.ORG  Mon Jun 11 21:10:14 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@hub.freebsd.org
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 85F6F16A41F
	for <freebsd-net@hub.freebsd.org>; Mon, 11 Jun 2007 21:10:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id 3098F13C4BF
	for <freebsd-net@hub.freebsd.org>; Mon, 11 Jun 2007 21:10:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5BLADqb077496
	for <freebsd-net@freefall.freebsd.org>; Mon, 11 Jun 2007 21:10:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5BLADEe077495;
	Mon, 11 Jun 2007 21:10:13 GMT (envelope-from gnats)
Date: Mon, 11 Jun 2007 21:10:13 GMT
Message-Id: <200706112110.l5BLADEe077495@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Cristian KLEIN <cristi@net.utcluj.ro>
Cc: 
Subject: Re: kern/113548: [dummynet] [patch] system hangs with dummynet
	queues
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Cristian KLEIN <cristi@net.utcluj.ro>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2007 21:10:14 -0000

The following reply was made to PR kern/113548; it has been noted by GNATS.

From: Cristian KLEIN <cristi@net.utcluj.ro>
To: bug-followup@FreeBSD.org,  littlesavage@orionet.ru
Cc:  
Subject: Re: kern/113548: [dummynet] [patch] system hangs with dummynet queues
Date: Mon, 11 Jun 2007 23:35:21 +0300

 I think the problem occurs because you use ipfw tags. As far as I know,
 ipfw tags are stored as mbuf_tags(9). Dummynet uses mbuf tags too to
 mark it's own packets. However, I suspect that in dn_tag_get(), dummynet
 incorrectly assumes it is the only one using mbuf_tags(9).
 
 Could you please apply the following patch? Also, could you test whether
 removing "tag 1" from ipfw rules has any impact?
 
 --- ip_dummynet.c.orig  Sat Jul 29 11:24:12 2006
 +++ ip_dummynet.c       Mon Jun 11 23:27:34 2007
 @@ -412,7 +412,7 @@
  static struct dn_pkt_tag *
  dn_tag_get(struct mbuf *m)
  {
 -    struct m_tag *mtag = m_tag_first(m);
 +    struct m_tag *mtag = m_tag_find(m, PACKET_TAG_DUMMYNET, NULL);
      KASSERT(mtag != NULL &&
             mtag->m_tag_cookie == MTAG_ABI_COMPAT &&
             mtag->m_tag_id == PACKET_TAG_DUMMYNET,
 
 -- 
 +-------------------------------------+
 | Cristian KLEIN                      |
 | Network Engineer                    |
 | Communication Center                |
 | Technical University of Cluj-Napoca |
 +-------------------------------------+
 | Tel: +40-264-401247, int. 247       |
 | WWW: http://www.cc.utcluj.ro        |
 +-------------------------------------+