From owner-freebsd-net@FreeBSD.ORG  Wed Jan  6 09:40:03 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 400D1106566C
	for <freebsd-net@hub.freebsd.org>; Wed,  6 Jan 2010 09:40:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 2F0708FC0A
	for <freebsd-net@hub.freebsd.org>; Wed,  6 Jan 2010 09:40:03 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o069e3QE095300
	for <freebsd-net@freefall.freebsd.org>; Wed, 6 Jan 2010 09:40:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o069e3V8095294;
	Wed, 6 Jan 2010 09:40:03 GMT (envelope-from gnats)
Date: Wed, 6 Jan 2010 09:40:03 GMT
Message-Id: <201001060940.o069e3V8095294@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Roman Bogorodskiy <novel@FreeBSD.org>
Cc: 
Subject: Re: kern/142197: [ndis] [patch] ndis is missing media status
 reporting
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Roman Bogorodskiy <novel@FreeBSD.org>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jan 2010 09:40:03 -0000

The following reply was made to PR kern/142197; it has been noted by GNATS.

From: Roman Bogorodskiy <novel@FreeBSD.org>
To: bug-followup@FreeBSD.org, onemda@gmail.com, rpaulo@FreeBSD.org
Cc:  
Subject: Re: kern/142197: [ndis] [patch] ndis is missing media status
 reporting
Date: Wed, 6 Jan 2010 12:32:42 +0300

 --uAKRQypu60I7Lcqm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hello,
 
 Seems like there's a minor problem with that:
 
 cc1: warnings being treated as errors
 /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c: In function 'ndis=
 _media_status':
 /usr/src/sys/modules/if_ndis/../../dev/if_ndis/if_ndis.c:2252: warning: pas=
 sing argument 4 of 'ndis_get_info' from incompatible pointer type
 *** Error code 1
 
 As ndis_get_info accepts 'int', not 'size_t', so after applying this:
 
 --- if_ndis.c.orig	2010-01-06 12:15:17.000000000 +0300
 +++ if_ndis.c	2010-01-06 12:17:03.000000000 +0300
 @@ -2243,7 +2243,7 @@
  	struct ieee80211vap *vap =3D ifp->if_softc;
  	struct ndis_softc *sc =3D vap->iv_ic->ic_ifp->if_softc;
  	uint32_t txrate;
 -	size_t len;
 +	int len;
 =20
  	if (!NDIS_INITIALIZED(sc))
  		return;
 
 it compiles fine.
 
 Roman Bogorodskiy
 
 --uAKRQypu60I7Lcqm
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.10 (FreeBSD)
 
 iJwEAQECAAYFAktEWLAACgkQgHRbOB2qykYkkQP9HBbpfcBkyEl7eLyZz1Egga8i
 MkkjIWtZLDYzfP4I40n1msmydvWPiiFMpXl7M7I4F9qx4dygWhFeYhTSpyRdpxQx
 aWk9c0exeYae5y+hjfciHZ4yEdJtV8A7yOkAXs4Sgi9hYaomWebkK4svUwbVyQsR
 nlb7YXKsPMnLUxkPtmo=
 =W1Zn
 -----END PGP SIGNATURE-----
 
 --uAKRQypu60I7Lcqm--