Date: Thu, 4 Jun 2015 18:35:56 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Jan Beich <jbeich@vfemail.net> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r388498 - head/multimedia/dvdstyler Message-ID: <20150604183556.57937749@kalimero.tijl.coosemans.org> In-Reply-To: <twun-ef5q-wny@vfemail.net> References: <201506040756.t547uJN4005594@svn.freebsd.org> <twun-ef5q-wny@vfemail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 04 Jun 2015 16:12:17 +0200 Jan Beich <jbeich@vfemail.net> wrote:
> Tijl Coosemans <tijl@FreeBSD.org> writes:
>> - Replace CXXFLAGS+=-std=c++11 with USE_CXXSTD.
> [...]
>> +USE_CXXSTD= gnu++11
> [...]
>> -.if ${CHOSEN_COMPILER_TYPE} == "gcc"
>> -CXXFLAGS+= -std=c++11
>> -.endif
>
> Why "gnu" dialect of c++11 ? If clang/libc++ fail to build the port
> otherwise you should say so in the commit message. At least r383466
> itself doesn't require "gnu".
>
> $ fgrep -i std x11-toolkits/wxgtk30/Makefile
> CXXFLAGS+= -std=c++11
Hmm, I see the gnu dialect as the normal case and strict standard
compliance as the special case requiring explanation. The reason is
that the compiler uses the gnu dialect by default and disables some
optimisations when you request strict compliance. If upstream relied
on strict compliance they would have added an -std flag themselves.
So in my opinion wxgtk30 should also use -std=gnu++11.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150604183556.57937749>