From owner-svn-src-all@FreeBSD.ORG Sun Nov 16 05:31:33 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CD59ACC4; Sun, 16 Nov 2014 05:31:33 +0000 (UTC) Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com [IPv6:2607:f8b0:4001:c03::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A955A59; Sun, 16 Nov 2014 05:31:33 +0000 (UTC) Received: by mail-ie0-f177.google.com with SMTP id tr6so1203479ieb.36 for ; Sat, 15 Nov 2014 21:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=TdBGAsENA7go24V9/9/eOtMIqevOmg8dWBOFfulTHik=; b=pyS3D0PdsrFp/34NxdmgtvUyjCfk8zeDhIBrkok9o8JW/dL6nH+nWDE9QVQ7XXHhsy 6djGU2SaKAIkzH5R1HHVjn8UNsLcWcJrCd02NkaDfnXJeoDdCt1TCIVtTq2hQvhBaCmM DK0TYL+NKYLONk6yWl+4HeAiszl6YuBQMywi9o1zP5n1xOb0hsTI6epmzT/l13xRg4Ps tD+JK9RmeDdbONyYQri5jVRx3b3dHwaOqAvJuvumA2j17gvDlZBEwGZtz6fv88CN7YSC C2XVxyyEw0TicXhl1KX93ydOkfEsKOxFBkL+Ls+ELY8ouqXceGUTHPvFlarrdB/RD0Xr HeRg== X-Received: by 10.107.164.75 with SMTP id n72mr12884836ioe.17.1416115892973; Sat, 15 Nov 2014 21:31:32 -0800 (PST) Received: from [192.168.20.5] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id p5sm3907763iga.5.2014.11.15.21.31.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 15 Nov 2014 21:31:32 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_F1B63001-3EAE-475F-B42B-FC9EF821AD8D"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r274573 - head/contrib/netbsd-tests/lib/libpthread From: Garrett Cooper In-Reply-To: Date: Sat, 15 Nov 2014 21:31:25 -0800 Message-Id: <22C52F4A-B9EC-4C32-9D26-474B7EF0CEF2@gmail.com> References: <201411160508.sAG58JdG055637@svn.freebsd.org> <546833FE.9060904@freebsd.org> <45B1482F-352E-4874-8A89-1EC225A32E93@gmail.com> <54683508.3030104@freebsd.org> To: Alfred Perlstein X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 05:31:34 -0000 --Apple-Mail=_F1B63001-3EAE-475F-B42B-FC9EF821AD8D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 15, 2014, at 21:26, Garrett Cooper wrote: > On Nov 15, 2014, at 21:24, Alfred Perlstein = wrote: >=20 >> On 11/15/14, 9:22 PM, Garrett Cooper wrote: >>> On Nov 15, 2014, at 21:19, Alfred Perlstein = wrote: >>>=20 >>>> This looks easy enough to fix under _thr_find_thread() in = libthread. >>>>=20 >>>> Any interest in fixing it? >>> Yes, if it=92s POSIXly correct and doesn=92t break everything else. >>>=20 >>>> Might be worth hacking _thr_find_thread() to take an ERRNO to = return based on NULL until we chase down all the paths into it just in = case EINVAL is a valid ptr. >>> K. Thanks for the hint! >>>=20 >>>> Also, just wondering what happens on other platforms, does it = elicit a crash? Ie. is NULL a safe value to pass in on other platforms? >>> I wish I knew what happened on !x86 platforms=85 I honestly don=92t = have access to ARM/MIPS/PowerPC, so I can=92t say :/. >>>=20 >>> Thanks! >>=20 >> Oh, I meant Linux and Solaris, or even other BSD. >=20 > Ah, good question. pho@ ran some of the tests in contrib/netbsd-tests = on Linux/OSX before to do a side-by-side comparison, but I haven=92t = setup the necessary environment to do that testing [yet]. FWIW, there=92s some weirdness with one of the testcases that was never = fully integrated in at Isilon where it blocks on a random mutex in = libthr=85 trying to figure out what=92s causing it to do that, but this = might be related... --Apple-Mail=_F1B63001-3EAE-475F-B42B-FC9EF821AD8D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUaDatAAoJEMZr5QU6S73eZy8IAK9A6R+XfpGWKPSqYT/cjDtp UupQUnew12ZiipVGl5MSDQBfGyl+ns16+JYmg3ZVsm/BY6XkeBhszhcr5ZNzCxxT fV1wLI7adeaEyKSe+R0kgV8NAgrcEHMm3OXk2ourHqtmuudnlBdwmjIUTQU018VS q5Gf+N++b3vftpp1H90nydIWzsusELoGg+OdlqB6JY3nudVhKpaOYT9IRBlKcT3q TGRYWq217sORjJHzgr5v4bljmmsTpFNaluKJKMe90GM3SYRcY4yTPCGM1c5nsEl+ tg4bEGsuRZskvbgEACK1d+lWkp1xPEnwt4BMKRzVJ6Wh5ABc2UY6mOVoVub9R4k= =ITZU -----END PGP SIGNATURE----- --Apple-Mail=_F1B63001-3EAE-475F-B42B-FC9EF821AD8D--