From owner-svn-src-all@freebsd.org Sat Feb 10 16:13:46 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9ADEEF07E57; Sat, 10 Feb 2018 16:13:46 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com [IPv6:2a00:1450:4010:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F1FC4853E7; Sat, 10 Feb 2018 16:13:45 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-lf0-x22e.google.com with SMTP id g72so15184134lfg.5; Sat, 10 Feb 2018 08:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Hcoh1hgpx7DXrsw4axUsVy8/UiH8uOXXu+gxRTEkhPg=; b=G/1dvoKTwzBKeXSuSLnz8v/9nu17cjf2nyLxaoLKX1CY42+6ig+hXtvFDaeG2z1jZ0 nJILGG5V92M/feOQTXY2E0j3FxniJZc28aaDIONPh8aybJrNlaXJ6q9F83OA/bpYE0Ql MhmHvt48FMFHWTm4dLAWT0l94yHCZDfeoCqVEjAaDzZ01k3BKsX/HiEwAHDhcNCFej+u GP1mHWH1arzOdSfOQuSbIDgC7ExcEk+fzE33RO17nTgcyv763o58FdKQBZI8zOFSz2WE B3VLWoLI2ME1knmEkT8BlYFLVEotQcVi9ZpdyqMaC7aKjhBA7JAWH1Dmj557kFrxyr1n F+bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Hcoh1hgpx7DXrsw4axUsVy8/UiH8uOXXu+gxRTEkhPg=; b=lBiLkGM2RgEuCvS0nq4Bg5EEnHMmP07+VkbeKKeOJZdpd2YJukHTZmTY9xhxKG05mr NSJvQaAhv4N3CXldAyfxt2WC6j0xAVdGd2l8duWF+ypgYfBs4Pc/10Msbz0B4HlxjKQI 771Y9bVqySnuh2yoGUYiPzx3cjsf8BDf11ch2oKAjygHY4H6nQs77HGW80gG02Xq6WO2 PzPMe08RxtbigO4bY+xE5is3F+OMXQGdLygq/1IVDPjWvW+i83QVkfqk9lgCnXJ4o0WK 5hGm4/m5rFwjYwYqIuUkIcelROg1SunzKjEyJ8jTOWwYK7nh2aj2RDDnFmT2pZ3ERr4s bjXw== X-Gm-Message-State: APf1xPCJ/VH3WPvLE9V4Mq0wXxmin9kH2zF2vW3T4IO9ElFveaHP/22n ykeJU0uUOWhw0qval3aTm0JAFvUQnou3OM5XlfgqBA== X-Google-Smtp-Source: AH8x226p9cKSIvYyBKp34jIjcpKS12gFfB407FO3QC9d0pUNmORNJxrMf9ZlnGuvMrGeJ63DMZPnl4cQ2c6L+q/hUGQ= X-Received: by 10.46.77.157 with SMTP id c29mr4255034ljd.116.1518279224157; Sat, 10 Feb 2018 08:13:44 -0800 (PST) MIME-Version: 1.0 Sender: chmeeedalf@gmail.com Received: by 10.46.75.1 with HTTP; Sat, 10 Feb 2018 08:13:43 -0800 (PST) In-Reply-To: References: <201802091946.w19Jkqb3038864@repo.freebsd.org> From: Justin Hibbits Date: Sat, 10 Feb 2018 10:13:43 -0600 X-Google-Sender-Auth: knT5JOVUO_WT8rRIxGH-sYBDCP8 Message-ID: Subject: Re: svn commit: r329077 - head/usr.bin/tftp To: Ed Maste Cc: Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Feb 2018 16:13:46 -0000 On Fri, Feb 9, 2018 at 7:22 PM, Ed Maste wrote: > On 9 February 2018 at 14:46, Conrad Meyer wrote: >> Author: cem >> Date: Fri Feb 9 19:46:51 2018 >> New Revision: 329077 >> URL: https://svnweb.freebsd.org/changeset/base/329077 >> >> Log: >> tftp(1): Fix libedit state corruption involving signals > > From https://ci.freebsd.org/job/FreeBSD-head-mips-build/391/console: > > 01:15:24 --- all_subdir_usr.bin/tftp --- > 01:15:24 --- main.o --- > 01:15:24 cc1: warnings being treated as errors > 01:15:24 /usr/src/usr.bin/tftp/main.c: In function 'main': > 01:15:24 /usr/src/usr.bin/tftp/main.c:182: warning: 'hist' may be used > uninitialized in this function > 01:15:24 /usr/src/usr.bin/tftp/main.c:181: warning: 'el' may be used > uninitialized in this function > After initializing these, I see the following interesting error: /home/chmeee/freebsd/head/usr.bin/tftp/main.c:181: warning: variable 'el' might be clobbered by 'longjmp' or 'vfork' /home/chmeee/freebsd/head/usr.bin/tftp/main.c:182: warning: variable 'hist' might be clobbered by 'longjmp' or 'vfork' This appears to be a known bug in gcc, at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=24239 so I don't know what the best way to fix it is. - Justin