From owner-freebsd-ports  Mon Feb 14 13: 9:52 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by builder.freebsd.org (Postfix) with ESMTP id 4AE60431A
	for <freebsd-ports@FreeBSD.org>; Mon, 14 Feb 2000 13:09:43 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id NAA13706;
	Mon, 14 Feb 2000 13:10:02 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from mailgw1.be.to (mailgw1.be.to [210.235.212.5])
	by builder.freebsd.org (Postfix) with ESMTP id 9A99E4090
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 14 Feb 2000 13:08:49 -0800 (PST)
Received: from mail1.be.to (point1.be.to [210.235.212.29])
	by mailgw1.be.to (8.9.3+3.2W/BETO.2.1-2000020313000035) with ESMTP id GAA29707
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Feb 2000 06:09:06 +0900
Received: from acidrain (ppp13-Mobara1.mtci.ne.jp [210.172.1.215])
	by mail1.be.to (8.8.8+3.0Wbeta13/BETO.2.0-1999110714000000) with SMTP id GAA23333
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Feb 2000 06:09:04 +0900
Received: (qmail 11170 invoked by uid 1001); 14 Feb 2000 21:08:40 -0000
Message-Id: <20000214210839.11169.qmail@dolphin.be.to>
Date: 14 Feb 2000 21:08:39 -0000
From: okazaki@be.to
Reply-To: okazaki@be.to
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/16716: Fix port: devel/portlint
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         16716
>Category:       ports
>Synopsis:       Fix port: devel/portlint
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 14 13:10:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     OKAZAKI Tetsurou
>Release:        FreeBSD 3.4-STABLE i386
>Organization:
Unknown
>Environment:

	ports/devel/portlint/src/portlint.pl,v 1.14 2000/02/02 21:07:39

>Description:

	Current portlint keeps quiet about some invalid `CATEGORIES' lines.

>How-To-Repeat:

	1. Move to a simple port directory, for a example:
	% cd ${PORTSDIR}/archives/arc

	2. Damage his Makefile as follows:
	% perl -pi -e 's/^CATEGORIES[+?]?=.*/CATEGORIES/g' Makefile

	3. And listen to the portlint talking:
	% portlint
	OK: checking pkg/COMMENT.
	OK: checking pkg/DESCR.
	OK: checking Makefile.
	OK: checking files/md5.
	OK: checking patches/patch-aa.
	OK: checking patches/patch-ab.
	OK: checking patches/patch-ac.
	looks fine.

>Fix:
	
	Apply the following patch.

diff -urN /usr/ports/devel/portlint/src/portlint.pl portlint/src/portlint.pl
--- /usr/ports/devel/portlint/src/portlint.pl	Thu Feb  3 17:32:24 2000
+++ portlint/src/portlint.pl	Tue Feb 15 00:17:44 2000
@@ -688,7 +688,7 @@
 			"not by \"$1\".");
 	}
 	print "OK: checking CATEGORIES.\n" if ($verbose);
-	if ($tmp !~ /\nCATEGORIES(?=)/) {
+	if ($tmp !~ /\nCATEGORIES([+?]?=)/) {
 		&perror("FATAL: CATEGORIES has to be there.");
 	}
 	if ($tmp =~ /\nCATEGORIES([^?+]=)/) {

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message