From owner-cvs-all@FreeBSD.ORG Sun Jul 20 05:04:47 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 83C4337B401; Sun, 20 Jul 2003 05:04:47 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D06C43F3F; Sun, 20 Jul 2003 05:04:44 -0700 (PDT) (envelope-from ru@sunbay.com) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h6KC4c0U051783 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 20 Jul 2003 15:04:41 +0300 (EEST) (envelope-from ru@sunbay.com) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h6KC4cah051782; Sun, 20 Jul 2003 15:04:38 +0300 (EEST) (envelope-from ru) Date: Sun, 20 Jul 2003 15:04:38 +0300 From: Ruslan Ermilov To: Bruce Evans Message-ID: <20030720120438.GD47250@sunbay.com> References: <200307201024.h6KAO9tk009943@repoman.freebsd.org> <20030720213903.J595@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5" Content-Disposition: inline In-Reply-To: <20030720213903.J595@gamplex.bde.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ed Makefile re.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2003 12:04:47 -0000 --+KJYzRxRHjYqLGl5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 20, 2003 at 09:57:26PM +1000, Bruce Evans wrote: > On Sun, 20 Jul 2003, Ruslan Ermilov wrote: >=20 > > ru 2003/07/20 03:24:09 PDT > > > > FreeBSD src repository > > > > Modified files: > > bin/ed Makefile re.c > > Log: > > Make this code WARNS=3D6 clean again (after GCC 3.1.1 import). >=20 > gcc-3.3? >=20 Typo. > The bug is in gcc-3.3, so it shouldn't be fixed here. `expr' may > be a better variable name than `exp' for a variable related to > expressions, but this is just a minor style issue. >=20 Why is this a bug in gcc? Compiling re.c,v 1.19 like this works: make WARNS=3D6 re.o DEBUG_FLAGS=3D-fno-builtin > pwd/pwd.c has regressed similarly (except 'lg' is a worse variable > name than `log' for a variable related to "logical"). >=20 > I think we mostly avoided mangling variables named `sin' but there > are some of these to demangle too. --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software Ltd, ru@FreeBSD.org FreeBSD committer --+KJYzRxRHjYqLGl5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE/GoVWUkv4P6juNwoRArlIAJ9Y3s/TvZBD66cUbGvdgvzpFk3fkACfQFq+ nAOk67TE4gnokmZlQs0EAZ0= =7SPA -----END PGP SIGNATURE----- --+KJYzRxRHjYqLGl5--