From owner-cvs-all@FreeBSD.ORG  Sat Oct 29 03:01:17 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C692816A420;
	Sat, 29 Oct 2005 03:01:17 +0000 (GMT)
	(envelope-from wpaul@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7C2B043D45;
	Sat, 29 Oct 2005 03:01:17 +0000 (GMT)
	(envelope-from wpaul@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9T31HM0083495;
	Sat, 29 Oct 2005 03:01:17 GMT
	(envelope-from wpaul@repoman.freebsd.org)
Received: (from wpaul@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9T31H3P083494;
	Sat, 29 Oct 2005 03:01:17 GMT (envelope-from wpaul)
Message-Id: <200510290301.j9T31H3P083494@repoman.freebsd.org>
From: Bill Paul <wpaul@FreeBSD.org>
Date: Sat, 29 Oct 2005 03:01:17 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/dev/txp if_txp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Oct 2005 03:01:18 -0000

wpaul       2005-10-29 03:01:17 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/txp          if_txp.c 
  Log:
  Remove call to txp_set_filter() from txp_attach(). txp_set_filter() needs
  the ifp, so you can't call it before doing if_alloc(). Also, there's
  really no need to call it here anyway: the code I originally ported from
  OpenBSD incorrectly set the station address only once at device attach
  time, instead of setting in txp_init(). This meant you couldn't change
  the address with ifconfig txp0 ether xx:xx:xx:xx:xx:xx. I added the
  call to txp_set_filter() in txp_init() to correct this, but forgot to
  remove the call from txp_attach(). Until now, it never mattered.
  
  With this fix, the txp driver tests good:
  
  txp0: <3Com 3cR990-TX-97 Etherlink with 3XP Processor> port 0xb800-0xb87f mem 0xe6800000-0xe683ffff irq 12 at device 10.0 on pci0
  txp0: Ethernet address: 00:01:03:d4:91:4f
  
  Revision  Changes    Path
  1.38      +0 -2      src/sys/dev/txp/if_txp.c