From owner-svn-src-all@FreeBSD.ORG  Mon Oct 31 05:11:19 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6FF4E106564A;
	Mon, 31 Oct 2011 05:11:19 +0000 (UTC)
	(envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
	by mx1.freebsd.org (Postfix) with ESMTP id 3EC0A8FC17;
	Mon, 31 Oct 2011 05:11:18 +0000 (UTC)
Received: from julian-mac.elischer.org (home-nat.elischer.org [67.100.89.137])
	(authenticated bits=0)
	by vps1.elischer.org (8.14.4/8.14.4) with ESMTP id p9V4VEYi089679
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
	Sun, 30 Oct 2011 21:31:19 -0700 (PDT)
	(envelope-from julian@freebsd.org)
Message-ID: <4EAE248E.1060507@freebsd.org>
Date: Sun, 30 Oct 2011 21:31:10 -0700
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US;
	rv:1.9.2.23) Gecko/20110920 Thunderbird/3.1.15
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@freebsd.org>
References: <201110302117.p9ULHgLD085245@svn.freebsd.org>
	<20111031042526.GA57014@FreeBSD.org>
In-Reply-To: <20111031042526.GA57014@FreeBSD.org>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, Marius Strobl <marius@freebsd.org>,
	src-committers@freebsd.org, svn-src-all@freebsd.org
Subject: Re: svn commit: r226947 - in head/sys: dev/esp sparc64/sbus
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Oct 2011 05:11:19 -0000

On 10/30/11 9:25 PM, Alexey Dokuchaev wrote:
> On Sun, Oct 30, 2011 at 09:17:42PM +0000, Marius Strobl wrote:
>> Author: marius
>> Date: Sun Oct 30 21:17:42 2011
>> New Revision: 226947
>> URL: http://svn.freebsd.org/changeset/base/226947
>>
>> Log:
>>    - Use device_t rather than the NetBSDish struct device.
> Hmm, I though that style(9) advises against this practice:
>
>      Avoid using typedefs for structure types.  Typedefs are problematic
>      because they do not properly hide their underlying type; [...]
>
>      When convention requires a typedef, make its name match the struct tag.
>      Avoid typedefs ending in _t, except as specified in Standard C or by
>      POSIX.
>
> Does these rules not apply for struct device for some reason?
>
> ./danfe
>
I agree we should be trying to get rid of the blah_t horrors. I think 
this went the wrong direction.