From owner-freebsd-scsi Tue Aug 20 17:46:26 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC8F337B400; Tue, 20 Aug 2002 17:46:22 -0700 (PDT) Received: from melchior.cuivre.fr.eu.org (melchior.enst.fr [137.194.161.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id EC40543E72; Tue, 20 Aug 2002 17:46:21 -0700 (PDT) (envelope-from thomas@cuivre.fr.eu.org) Received: from melusine.cuivre.fr.eu.org (melusine.enst.fr [137.194.160.34]) by melchior.cuivre.fr.eu.org (Postfix) with ESMTP id 05DA710E10; Wed, 21 Aug 2002 02:46:20 +0200 (CEST) Received: by melusine.cuivre.fr.eu.org (Postfix, from userid 1000) id BC7202C3D1; Wed, 21 Aug 2002 02:46:14 +0200 (CEST) Date: Wed, 21 Aug 2002 02:46:14 +0200 From: Thomas Quinot To: Nate Lawson Cc: scsi@freebsd.org, current@freebsd.org Subject: Re: Proliferating quirk table entries Message-ID: <20020821024614.A722@melusine.cuivre.fr.eu.org> Reply-To: thomas@cuivre.fr.eu.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5i In-Reply-To: ; from nate@root.org on Fri, Aug 16, 2002 at 03:39:01PM -0700 X-message-flag: WARNING! Using Outlook can damage your computer. Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Le 2002-08-17, Nate Lawson écrivait : > I'm working on cleaning up quirk entries in scsi_da.c, especially ones > related to READ/WRITE 6->10 escalation. For those just joining in, there > is a function (cmd6workaround) that handles a R/W6 error by translating > the cdb to 10 bytes and restarting it. It might be worthwhile moving this to some generic part in the CAM framework, instead of having it in the da driver. Similar promotion is performed for some commands (MODE_{SELECT,SENSE}_6 as well as {READ,WRITE}_6) in a rather ad hoc fashion in atapi-cam. At least the cmd6workaround function should be factored in some way; as for the try 6 -> fail -> retry 10 process, however, I am not sure this can be readily generalised to ATAPI devices (which are explicitly specified to only support the _10 variants) as these tend to have very strange reactions to CDBs they cannot handle properly. Thomas. -- Thomas.Quinot@Cuivre.FR.EU.ORG To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message