From owner-freebsd-current@FreeBSD.ORG  Tue Sep 25 00:38:59 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 49D0C106566C;
	Tue, 25 Sep 2012 00:38:59 +0000 (UTC)
	(envelope-from rysto32@gmail.com)
Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id C8FBC8FC12;
	Tue, 25 Sep 2012 00:38:58 +0000 (UTC)
Received: by vbmv11 with SMTP id v11so8599547vbm.13
	for <multiple recipients>; Mon, 24 Sep 2012 17:38:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=G4cw9SJL7Z3Bt3dz/uXXrz94kwRf8hL3GKPBdUY5dVc=;
	b=Eg7xOBLGpQqjeot9ltpX26AhUetLtQzie0FcIEsOBy5xdsvfZ7Nv3/T7D10McgomLx
	6TWUmbkNRuVcRrFQmGCZLSs8Ia++pgIJskOeyTtxNMsKpHu97N0vcBS/mM8j+VndWAuh
	sGswcR3IGAZvuu8CaOMmxCWa3Aou7xt+ybSuVSpW4wIvGLkk3XKYJeDjCQDamZJN0Kdu
	BWPDPTFYl5RlqgyGuWNfw2GQfJw6pgvltW3yeoYOvnGhjKlsJS/KpP7hpfvANG6U+/ik
	sNzX8txiF2cwkYXBtZs02sUBmvi6Oeq51n1can5X/qSzikR3pXx85sy+dThqp4jeD2Bd
	qmLw==
MIME-Version: 1.0
Received: by 10.52.36.76 with SMTP id o12mr6763270vdj.40.1348533538044; Mon,
	24 Sep 2012 17:38:58 -0700 (PDT)
Received: by 10.58.207.114 with HTTP; Mon, 24 Sep 2012 17:38:57 -0700 (PDT)
In-Reply-To: <AE489E37693F45B887BDFB230EFBB46B@multiplay.co.uk>
References: <20120923195357.GO1454@garage.freebsd.pl>
	<1735E492-3C3C-491A-82E2-884E976B4BC4@gid.co.uk>
	<20120923222520.GS1454@garage.freebsd.pl>
	<D637D49E-27B3-4169-BC27-D5A7409040B9@gid.co.uk>
	<20CC6F2BF08D47ED802318697542A15D@multiplay.co.uk>
	<20120924161654.GA1413@garage.freebsd.pl>
	<AE489E37693F45B887BDFB230EFBB46B@multiplay.co.uk>
Date: Mon, 24 Sep 2012 20:38:57 -0400
Message-ID: <CAFMmRNxGc8HOsEP6vtmr_90Cczh9PeWn31dSZYKX6opE=_m_sw@mail.gmail.com>
From: Ryan Stone <rysto32@gmail.com>
To: Steven Hartland <killing@multiplay.co.uk>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org
Subject: Re: ZFS TRIM support committed to HEAD.
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2012 00:38:59 -0000

On Mon, Sep 24, 2012 at 1:03 PM, Steven Hartland
<killing@multiplay.co.uk> wrote:
> Ahh yes looks like ATA supports BIO_DELETE via ATA_CFA_ERASE if the drive
> announces ATA_PROTO_CFA, so I can only assume this is failing when it
> shouldn't.
>
> Might be nice to investigate what's happening and fix, but as ATA is
> being replaced by CAM ATA not sure its worth it?

I believe that the code that you are looking at refers to a old
command that is only implemented by CompactFlash cards.  The ad(4)
driver does not currently support the TRIM command.  I have an
internal patch that implements it for FreeBSD 8.2; if there's interest
I could try to dig it out.