Date: Sun, 21 Oct 2018 15:45:20 +0000 From: Glen Barber <gjb@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: Jan Beich <jbeich@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339436 - in head: . contrib/gcc gnu/usr.bin/cc/cc_tools lib/clang release sys/conf sys/sys Message-ID: <20181021154520.GB13668@FreeBSD.org> In-Reply-To: <F64E20B4-576A-44DA-B727-EFDA7D4EF51E@FreeBSD.org> References: <201810190037.w9J0blks031617@repo.freebsd.org> <o9bo-oxuj-wny@FreeBSD.org> <F64E20B4-576A-44DA-B727-EFDA7D4EF51E@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--IiVenqGWf+H9Y6IX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sun, Oct 21, 2018 at 11:55:20AM +0200, Dimitry Andric wrote:
> On 21 Oct 2018, at 04:08, Jan Beich <jbeich@FreeBSD.org> wrote:
> >=20
> > Glen Barber <gjb@FreeBSD.org> writes:
> >=20
> >> Modified: head/lib/clang/llvm.build.mk
> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> >> --- head/lib/clang/llvm.build.mk Fri Oct 19 00:24:23 2018 (r339435)
> >> +++ head/lib/clang/llvm.build.mk Fri Oct 19 00:37:47 2018 (r339436)
> >> @@ -17,7 +17,7 @@ CFLAGS+=3D -I${LLVM_SRCS}/include
> >> CFLAGS+=3D -DLLVM_BUILD_GLOBAL_ISEL
> >> CFLAGS+=3D -D__STDC_LIMIT_MACROS
> >> CFLAGS+=3D -D__STDC_CONSTANT_MACROS
> >> -#CFLAGS+=3D -DNDEBUG
> >> +CFLAGS+=3D -DNDEBUG
> >=20
> > Would Clang still hit asserts instead of crashing with cryptic messages?
>=20
> In llvm, assertions (and various other internal consistency checks) are
> turned off by defining NDEBUG. So indeed, if something in the internal
> state goes in an unexpected direction, you could get crashes or other
> "interesting" effects.
>=20
> That said, the resulting executable(s) should run somewhat faster, and
> be somewhat smaller. I think we have always done this for stable
> branches and releases.
>=20
I think I screwed up, and changed this in the wrong branch. I'm looking
into the "why", but the commit to head in this case should be reverted
(I'll take care of it if it was not already done), and this particular
change should be applied to stable/12 (which I will also take care of).
I first want to look through our docs to understand how I messed this
up.
Glen
--IiVenqGWf+H9Y6IX
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAlvMnxAACgkQAxRYpUeP
4pONshAAhk9i9Q5ywgS5r5qhNZybLbreAYTXU8gkHmuO75TzKVWaTJPJ/+IhYmTy
E/CTEdSmTsaamBP15xMLYEHf9A0lWNqypVORyQS4FUqRycBz+owkzbOGzJtq86OF
uT2BA/N6/i9kcbFcjHDXr1YAnhxhGO8VFw5mmNtfH6asLvB14hGQ5huQAOR1yD/F
UFhbS0Fqs1iJTGyRtDtn0fLdS2OoR8suUaOMy8fl/kqKmdEJy0Tpto/Gng3xCE87
iWSOExodsGVTOo3X5NzlsoI2MXyOV0icyMV61WWKhCqXXyquunoXu7oGLCwB/j96
hkR8GvNJxoTCDwhZmSPGjoUNlfXtHv/IHVmAZuCEqD3DZxg7LnPEkh3NNM1UzGZD
o84ij+9dA/fEC2FhCETgAGRzeIcv2x+MaywbiYCpzecuVO2NsNgPDZqJ7sZ+CFFo
8fD0xk5Dj2tokC2J/Ne6c24z/MyT6JJy60Vcf1gfBUBsQtIqRI4PBBXTrTESD6Ba
672yjvE2b3TgpM3tR3F7y3bgQSsB5B/rXUvXe9BnVMGvjvvN7Vyq3V6lK05a/Gt/
ATxvqajLIwkITeby8r4pdOana1X1MWUnOi/+EVNDy3/UBF1wukGrrUL3MxbGGrD1
TCv4dm/wUJvPN2YOp6PVigMdS4C9ZQiuPqvxAp3d9vrml2QvHzU=
=rqtj
-----END PGP SIGNATURE-----
--IiVenqGWf+H9Y6IX--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181021154520.GB13668>